Skip to content

Commit ff70d69

Browse files
committed
better readme
1 parent bdef8c4 commit ff70d69

File tree

7 files changed

+56
-50
lines changed

7 files changed

+56
-50
lines changed

03-box-model/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Here is [your objective](http://lewagon.github.io/html-css-challenges/03-box-mod
1010
- You should start with the following structure for your page
1111

1212
```html
13-
<div class="container">
13+
<div id="container">
1414
<div class="card"></div>
1515
<div class="card"></div>
1616
<div class="card"></div>

04-advanced-selectors/README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,16 @@ To design your lists of icons, you'll have to change the `block` behavior of lis
5151
Here are the corresponding CSS rules.
5252

5353
```css
54-
.list-inline > li{
54+
.list-inline > li {
5555
display: inline-block;
5656
width: 90px;
5757
}
58+
```
59+
60+
**Another CSS trick**: even inline, a list keeps a left padding that you should kill.
61+
62+
```css
63+
.list-inline {
64+
padding-left: 0px;
65+
}
5866
```

05-fixed-sidebar/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,27 @@
11
## Background & Objectives
22

3-
Build a cool layout with fixed sidebar and scrollable page content.
3+
Build a nice layout with a fixed sidebar and a scrollable page content.
44

55
## Specs
66

77
Here is [your objective](http://lewagon.github.io/html-css-challenges/05-fixed-sidebar/).
88

99
## Tips & Resources
1010

11-
Sometimes you need internal links, refering to sections of your current page, not to other pages. You can code them like this:
11+
Sometimes you need internal links, referring to sections of your page, not to other pages of your site. Here is how you do that:
1212

1313
```html
1414
<!-- In your nav list -->
1515
<a href="#summary">Infos</a>
1616
<a href="#favorite-movies">Movies</a>
1717
<a href="#help">Infos</a>
1818

19+
<!-- [...] -->
20+
1921
<!-- Now in your page content -->
2022
<div id="summary">your summary</div>
2123
<div id="favorite-movies">your favorite movies</div>
2224
<div id="help">some help section</div>
2325
```
2426

25-
Later on we will add smoothscroll animations on internal links. That will be good stuff!
27+
Later on, we will add a nice smoothscroll effect on such links. But wait for next week!

05-fixed-sidebar/style.css

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ a:hover{
4848
.card{
4949
background: white;
5050
text-align: center;
51-
padding: 20px;
51+
padding: 30px 50px;
5252
margin-bottom: 20px;
5353
border-radius: 4px;
5454
box-shadow: 0px 1px 2px 0px rgba(0, 0, 0, 0.2);
@@ -110,11 +110,9 @@ a:hover{
110110
/* Fixed sidebar layout */
111111

112112
#content{
113-
width: 80%;
114-
padding-left: 5%;
115-
padding-right: 5%;
116113
position: relative;
117-
left: 10%;
114+
margin-left: 120px;
115+
padding: 20px 60px;
118116
}
119117

120118
#sidebar {
@@ -123,7 +121,7 @@ a:hover{
123121
background-color: #384047;
124122
top: 0px;
125123
bottom: 0px;
126-
width: 10%;
124+
width: 120px;
127125
text-align: center;
128126
}
129127

06-profile-dashboard/README.md

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,25 @@
11
## Background & Objectives
22

33
Create a cool profile dashboard by inserting your infos into a nice 2D layout. You'll
4-
have to use most standard CSS positionning techniques.
4+
have to use a lot of CSS positionning techniques.
55

66
## Specs
77

88
Here is [the objective](http://lewagon.github.io/html-css-challenges/06-profile-dashboard/). Before inserting your different profile informations into the layout, start by building this layout step-by-step :
99

10-
1. Create and position the main centered container.
11-
1. Then, add two floating `<div>` into this container. In order to get the main container wrap these two div, you'll have to use a third div with `clear: both;` CSS property (this is a classic CSS trick).
12-
1. Below the two floating div, add the bottom footer division. Notice the absolute position of the icon list at bottom-right of this footer div. You will have to use a `relative > absolute` CSS pattern to get this result.
10+
- Create and center the main container.
11+
- Add two floating `<div>` into this container. In order to get the main container wrap these two div, you'll have to use a third div with `clear: both;` CSS property after the two floating ones (this is a classic CSS trick).
1312

14-
## Deploy
1513

16-
Your turn! Don't forget to **commit and deploy your code using Github app**.
14+
```html
15+
<div id="container">
16+
<div id="left"></div>
17+
<div id="right"></div>
18+
<div class="clear"></div>
19+
<div id="footer">
20+
<ul class="list-inline"></ul>
21+
</div>
22+
</div>
23+
```
24+
25+
- Finally, add the bottom footer division. Notice the absolute position of the icon list at bottom-right of this footer div. You will have to use a `relative > absolute` CSS pattern to obtain such result.

06-profile-dashboard/index.html

Lines changed: 18 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,18 @@
1010
<body>
1111

1212
<div id="wrapper">
13-
1413
<div id="left-container">
1514
<div class="card text-center">
1615
<img src="../shared/images/boris.jpg" alt="Boris Paillard" id="img-profile" class="img-circle">
1716
<h1>Boris Paillard</h1>
1817
<h2>CEO @Le Wagon</h2>
19-
2018
<p>
2119
Boris got bored from financial markets and <strong>took the plunge in web-development</strong>. He perfectly understands what beginners need. He founded Le Wagon, and built its site and pedagogical platforms.
2220
</p>
23-
2421
<a href="" class="btn-danger">more infos <i class="fa fa-angle-double-right"></i></a>
2522
</div>
26-
2723
<div class="card text-center">
28-
<ul class="nav-icons">
24+
<ul class="list-inline">
2925
<li class="text-center">
3026
<a href="#">
3127
<i class="fa fa-facebook"></i> <br>Facebook
@@ -44,7 +40,6 @@ <h2>CEO @Le Wagon</h2>
4440
</ul>
4541
</div>
4642
</div>
47-
4843
<div id="right-container" class="card">
4944
<h2>My Favorite movies</h2>
5045
<table id="movies">
@@ -79,35 +74,29 @@ <h3>Alien</h3>
7974
</tbody>
8075
</table>
8176
</div>
82-
8377
<div class="clear">
8478
</div>
85-
8679
<div class="card" id="footer">
8780
<h2>About this page</h2>
8881
This page has been coded during the front-end kit <a href="http://lewagon.org" target="_blank">@LeWagon</a> and that was probably the best experience during my entire life.
89-
<div class="share">
90-
<ul class="nav-icons">
91-
<li>
92-
<a href="#">
93-
<i class="fa fa-heart"></i>
94-
</a>
95-
</li>
96-
<li>
97-
<a href="#">
98-
<i class="fa fa-share"></i>
99-
</a>
100-
</li>
101-
<li>
102-
<a href="#">
103-
<i class="fa fa-star"></i>
104-
</a>
105-
</li>
106-
</ul>
107-
</div>
82+
<ul class="list-inline" id="share">
83+
<li>
84+
<a href="#">
85+
<i class="fa fa-heart"></i>
86+
</a>
87+
</li>
88+
<li>
89+
<a href="#">
90+
<i class="fa fa-share"></i>
91+
</a>
92+
</li>
93+
<li>
94+
<a href="#">
95+
<i class="fa fa-star"></i>
96+
</a>
97+
</li>
98+
</ul>
10899
</div>
109-
110100
</div>
111-
112101
</body>
113102
</html>

06-profile-dashboard/style.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,16 @@ a:hover{
7777
text-align: center;
7878
}
7979

80-
.nav-icons {
80+
.list-inline {
8181
padding-left: 0;
8282
}
8383

84-
.nav-icons li {
84+
.list-inline li {
8585
display: inline-block;
8686
width: 90px;
8787
}
8888

89-
.nav-icons li i{
89+
.list-inline li i{
9090
font-size: 25px;
9191
}
9292

@@ -132,7 +132,7 @@ a:hover{
132132
padding: 10px 400px 60px 20px;
133133
}
134134

135-
.share{
135+
#share{
136136
position: absolute;
137137
text-align: center;
138138
bottom: 10px;

0 commit comments

Comments
 (0)