From bea974976fc5391840e9580559c7c6fb9caed2b4 Mon Sep 17 00:00:00 2001
From: Devansh Sehgal <devanshsehgal02@gmail.com>
Date: Thu, 9 Oct 2025 04:47:56 +0530
Subject: [PATCH 1/3] Hide internal topics by default when no preference exists
 (closes #1073)

---
 .../src/components/Topics/List/ListPage.tsx   | 26 ++++++++++++-------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/frontend/src/components/Topics/List/ListPage.tsx b/frontend/src/components/Topics/List/ListPage.tsx
index d8508175c..00390e0ca 100644
--- a/frontend/src/components/Topics/List/ListPage.tsx
+++ b/frontend/src/components/Topics/List/ListPage.tsx
@@ -22,19 +22,27 @@ const ListPage: React.FC = () => {
     if (!searchParams.has('perPage')) {
       searchParams.set('perPage', String(PER_PAGE));
     }
-    if (
-      !!localStorage.getItem('hideInternalTopics') &&
-      !searchParams.has('hideInternal')
-    ) {
-      searchParams.set('hideInternal', 'true');
+    // If URL doesn't specify it, derive from localStorage (default = true when missing)
+    if (!searchParams.has('hideInternal')) {
+      const stored = localStorage.getItem('hideInternalTopics');
+      const shouldHide = stored === null ? true : stored === 'true';
+      searchParams.set('hideInternal', String(shouldHide));
+      // persist the default so it sticks across pages
+      if (stored === null) localStorage.setItem('hideInternalTopics', 'true');
+    } else {
+      // sync localStorage if URL has it set
+      const raw =  searchParams.get('hideInternal');
+      const norm = raw === 'true' || raw === 'false' ? raw : 'true'; // default to true if malformed
+      localStorage.setItem('hideInternalTopics', norm);
+      if (norm !== raw) searchParams.set('hideInternal', norm); // sync URL if malformed
     }
     setSearchParams(searchParams);
   }, []);
 
   const handleSwitch = () => {
-    if (searchParams.has('hideInternal')) {
-      localStorage.removeItem('hideInternalTopics');
-      searchParams.delete('hideInternal');
+    if (searchParams.get('hideInternal') === 'true') {
+      localStorage.setItem('hideInternalTopics', 'false');
+      searchParams.set('hideInternal', 'false');
     } else {
       localStorage.setItem('hideInternalTopics', 'true');
       searchParams.set('hideInternal', 'true');
@@ -66,7 +74,7 @@ const ListPage: React.FC = () => {
         <label>
           <Switch
             name="ShowInternalTopics"
-            checked={!searchParams.has('hideInternal')}
+            checked={searchParams.get('hideInternal') === 'false'}
             onChange={handleSwitch}
           />
           Show Internal Topics

From dd9d8aba5eccc5f3183d2cc583765e4ce20923b4 Mon Sep 17 00:00:00 2001
From: Devansh Sehgal <devanshsehgal02@gmail.com>
Date: Thu, 9 Oct 2025 09:42:12 +0530
Subject: [PATCH 2/3] Fix test assertions for hideInternalTopics toggle
 behavior

Update the test in ListPage.spec.tsx to correctly assert the initial
state of 'hideInternalTopics' as truthy, then toggling to falsy and
back to truthy. This ensures the test matches the component's new behavior.
---
 .../src/components/Topics/List/__tests__/ListPage.spec.tsx  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/frontend/src/components/Topics/List/__tests__/ListPage.spec.tsx b/frontend/src/components/Topics/List/__tests__/ListPage.spec.tsx
index c82932953..ff113cf82 100644
--- a/frontend/src/components/Topics/List/__tests__/ListPage.spec.tsx
+++ b/frontend/src/components/Topics/List/__tests__/ListPage.spec.tsx
@@ -36,11 +36,11 @@ describe('ListPage Component', () => {
       const switchInput = screen.getByLabelText('Show Internal Topics');
       expect(switchInput).toBeInTheDocument();
 
-      expect(global.localStorage.getItem('hideInternalTopics')).toBeNull();
-      await userEvent.click(switchInput);
       expect(global.localStorage.getItem('hideInternalTopics')).toBeTruthy();
       await userEvent.click(switchInput);
-      expect(global.localStorage.getItem('hideInternalTopics')).toBeNull();
+      expect(global.localStorage.getItem('hideInternalTopics')).toBeFalsy();
+      await userEvent.click(switchInput);
+      expect(global.localStorage.getItem('hideInternalTopics')).toBeTruthy();
     });
 
     it('renders the TopicsTable', () => {

From ab9807b4663751696845fe43817fb2f398bb363e Mon Sep 17 00:00:00 2001
From: Devansh Sehgal <devanshsehgal02@gmail.com>
Date: Thu, 9 Oct 2025 09:43:23 +0530
Subject: [PATCH 3/3] Run lint:fix

---
 frontend/src/components/Topics/List/ListPage.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/Topics/List/ListPage.tsx b/frontend/src/components/Topics/List/ListPage.tsx
index 00390e0ca..1f4151a93 100644
--- a/frontend/src/components/Topics/List/ListPage.tsx
+++ b/frontend/src/components/Topics/List/ListPage.tsx
@@ -31,7 +31,7 @@ const ListPage: React.FC = () => {
       if (stored === null) localStorage.setItem('hideInternalTopics', 'true');
     } else {
       // sync localStorage if URL has it set
-      const raw =  searchParams.get('hideInternal');
+      const raw = searchParams.get('hideInternal');
       const norm = raw === 'true' || raw === 'false' ? raw : 'true'; // default to true if malformed
       localStorage.setItem('hideInternalTopics', norm);
       if (norm !== raw) searchParams.set('hideInternal', norm); // sync URL if malformed