clean codes.

Author: hantsy

pom.xml

@@ -14,7 +14,7 @@
     <parent>
         <groupId>org.springframework.boot</groupId>
         <artifactId>spring-boot-starter-parent</artifactId>
-        <version>2.1.3.RELEASE</version>
+        <version>2.1.6.RELEASE</version>
         <relativePath/> <!-- lookup parent from repository -->
     </parent>
 
@@ -82,13 +82,11 @@
         <dependency>
             <groupId>io.rest-assured</groupId>
             <artifactId>rest-assured</artifactId>
-            <version>3.1.0</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>io.rest-assured</groupId>
             <artifactId>json-path</artifactId>
-            <version>3.1.0</version>
             <scope>test</scope>
         </dependency>
         <dependency>

src/main/java/com/example/demo/config/SecurityConfig.java

@@ -1,6 +1,6 @@
 package com.example.demo.config;
 
-import com.example.demo.security.jwt.JwtConfigurer;
+import com.example.demo.security.jwt.JwtSecurityConfigurer;
 import com.example.demo.security.jwt.JwtTokenProvider;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
@@ -39,7 +39,7 @@ protected void configure(HttpSecurity http) throws Exception {
                 .antMatchers(HttpMethod.GET, "/v1/vehicles/**").permitAll()
                 .anyRequest().authenticated()
             .and()
-            .apply(new JwtConfigurer(jwtTokenProvider));
+            .apply(new JwtSecurityConfigurer(jwtTokenProvider));
         //@formatter:on
     }
 

src/main/java/com/example/demo/security/jwt/InvalidJwtAuthenticationException.java

@@ -3,7 +3,12 @@
 import org.springframework.security.core.AuthenticationException;
 
 public class InvalidJwtAuthenticationException extends AuthenticationException {
-    public InvalidJwtAuthenticationException(String e) {
+    /**
+	 * 
+	 */
+	private static final long serialVersionUID = -761503632186596342L;
+
+	public InvalidJwtAuthenticationException(String e) {
         super(e);
     }
 }

src/main/java/com/example/demo/security/jwt/JwtProperties.java

@@ -1,6 +1,5 @@
 package com.example.demo.security.jwt;
 
-import org.springframework.beans.factory.annotation.Value;
 import org.springframework.boot.context.properties.ConfigurationProperties;
 
 import lombok.Data;
@@ -11,5 +10,6 @@ public class JwtProperties {
 
 	private String secretKey = "secret";
 
-	private long validityInMilliseconds = 3600000; // 1h
+	//validity in milliseconds
+	private long validityInMs = 3600000; // 1h
 }

src/main/java/com/example/demo/security/jwt/JwtConfigurer.java renamed to src/main/java/com/example/demo/security/jwt/JwtSecurityConfigurer.java

@@ -5,17 +5,17 @@
 import org.springframework.security.web.DefaultSecurityFilterChain;
 import org.springframework.security.web.authentication.UsernamePasswordAuthenticationFilter;
 
-public class JwtConfigurer extends SecurityConfigurerAdapter<DefaultSecurityFilterChain, HttpSecurity> {
+public class JwtSecurityConfigurer extends SecurityConfigurerAdapter<DefaultSecurityFilterChain, HttpSecurity> {
 
     private JwtTokenProvider jwtTokenProvider;
 
-    public JwtConfigurer(JwtTokenProvider jwtTokenProvider) {
+    public JwtSecurityConfigurer(JwtTokenProvider jwtTokenProvider) {
         this.jwtTokenProvider = jwtTokenProvider;
     }
 
     @Override
     public void configure(HttpSecurity http) throws Exception {
-        JwtTokenFilter customFilter = new JwtTokenFilter(jwtTokenProvider);
+        JwtTokenAuthenticationFilter customFilter = new JwtTokenAuthenticationFilter(jwtTokenProvider);
         http.exceptionHandling()
         .authenticationEntryPoint(new JwtAuthenticationEntryPoint())
         .and()

src/main/java/com/example/demo/security/jwt/JwtTokenFilter.java renamed to src/main/java/com/example/demo/security/jwt/JwtTokenAuthenticationFilter.java

@@ -11,11 +11,11 @@
 import javax.servlet.http.HttpServletRequest;
 import java.io.IOException;
 
-public class JwtTokenFilter extends GenericFilterBean {
+public class JwtTokenAuthenticationFilter extends GenericFilterBean {
 
     private JwtTokenProvider jwtTokenProvider;
 
-    public JwtTokenFilter(JwtTokenProvider jwtTokenProvider) {
+    public JwtTokenAuthenticationFilter(JwtTokenProvider jwtTokenProvider) {
         this.jwtTokenProvider = jwtTokenProvider;
     }
 

src/main/java/com/example/demo/security/jwt/JwtTokenProvider.java

@@ -41,7 +41,7 @@ public String createToken(String username, List<String> roles) {
         claims.put("roles", roles);
 
         Date now = new Date();
-        Date validity = new Date(now.getTime() + jwtProperties.getValidityInMilliseconds());
+        Date validity = new Date(now.getTime() + jwtProperties.getValidityInMs());
 
         return Jwts.builder()//
             .setClaims(claims)//

src/main/java/com/example/demo/web/AuthController.java renamed to src/main/java/com/example/demo/web/AuthenticationController.java

@@ -21,7 +21,7 @@
 
 @RestController
 @RequestMapping("/auth")
-public class AuthController {
+public class AuthenticationController {
 
     @Autowired
     AuthenticationManager authenticationManager;

src/main/java/com/example/demo/web/AuthenticationRequest.java

@@ -12,6 +12,10 @@
 @NoArgsConstructor
 @AllArgsConstructor
 public class AuthenticationRequest implements Serializable {
-    private String username;
+    /**
+	 * 
+	 */
+	private static final long serialVersionUID = -6986746375915710855L;
+	private String username;
     private String password;
 }