Skip to content

Commit 4af8f66

Browse files
author
Piotr Buchman
committed
Applied most of code review comments
1 parent b8c8b8e commit 4af8f66

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

query/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ dependencies {
1717
testCompile 'junit:junit:4.11'
1818
testCompile 'org.hamcrest:hamcrest-library:1.3'
1919
testCompile 'org.mockito:mockito-core:1.9.5'
20-
testCompile project(":core").sourceSets.test.output
20+
testCompile project(':core').sourceSets.test.output
2121
}
2222

2323
jar {

query/src/main/java/io/keen/client/java/CachedDatasetRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ URL getRequestURL(RequestUrlBuilder urlBuilder, String projectId) throws KeenQue
9191
};
9292
}
9393

94-
static KeenQueryRequest deleteRequest(String datasetName) {
94+
static KeenQueryRequest deletionRequest(String datasetName) {
9595
return new CachedDatasetRequest(HttpMethods.DELETE, true, datasetName) {
9696

9797
@Override

query/src/main/java/io/keen/client/java/CachedDatasetsClient.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import java.util.List;
77
import java.util.Set;
88

9-
public class CachedDatasetsClient implements CachedDatasets {
9+
class CachedDatasetsClient implements CachedDatasets {
1010

1111
private KeenQueryClient keenQueryClient;
1212

@@ -44,12 +44,12 @@ public List<DatasetDefinition> getDefinitionsByProject() throws IOException {
4444
public List<DatasetDefinition> getDefinitionsByProject(Integer limit, String afterName) throws IOException {
4545
KeenQueryRequest request = CachedDatasetRequest.definitionsByProjectRequest(limit, afterName);
4646

47-
return DatasetDefinition.collectionFromMap(keenQueryClient.getMapResponse(request));
47+
return DatasetDefinition.definitionsFromMap(keenQueryClient.getMapResponse(request));
4848
}
4949

5050
@Override
5151
public boolean delete(String datasetName) throws IOException {
52-
KeenQueryRequest request = CachedDatasetRequest.deleteRequest(datasetName);
52+
KeenQueryRequest request = CachedDatasetRequest.deletionRequest(datasetName);
5353

5454
return keenQueryClient.getMapResponse(request).isEmpty();
5555
}

query/src/main/java/io/keen/client/java/DatasetDefinition.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public class DatasetDefinition {
2525

2626
private DatasetQuery query;
2727

28-
static DatasetDefinition fromMap(Map<String, Object> properties) {
28+
@SuppressWarnings("unchecked")
29+
static DatasetDefinition fromMap(Map<String, ?> properties) {
2930
DatasetDefinition definition = new DatasetDefinition();
3031
definition.datasetName = (String) properties.get("dataset_name");
3132
definition.displayName = (String) properties.get("display_name");
@@ -34,18 +35,16 @@ static DatasetDefinition fromMap(Map<String, Object> properties) {
3435
definition.lastScheduledDate = (String) properties.get("last_scheduled_date");
3536
definition.latestSubtimeframeAvailable = (String) properties.get("latest_subtimeframe_available");
3637
definition.millisecondsBehind = String.valueOf(properties.get("milliseconds_behind"));
37-
//noinspection unchecked
3838
definition.indexBy = (List<String>) properties.get("index_by");
39-
//noinspection unchecked
4039
definition.query = DatasetQuery.fromMap((Map<String, Object>) properties.get("query"));
4140
return definition;
4241
}
4342

44-
static List<DatasetDefinition> collectionFromMap(Map<String, Object> properties) {
43+
@SuppressWarnings("unchecked")
44+
static List<DatasetDefinition> definitionsFromMap(Map<String, ?> properties) {
4545
if (properties.get("datasets") == null) {
4646
return Collections.emptyList();
4747
}
48-
//noinspection unchecked
4948
List<Map<String, Object>> datasets = (List<Map<String, Object>>) properties.get("datasets");
5049
List<DatasetDefinition> definitions = new LinkedList<DatasetDefinition>();
5150

query/src/main/java/io/keen/client/java/DatasetQuery.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ public class DatasetQuery {
2323

2424
private List<Filter> filters;
2525

26+
@SuppressWarnings("unchecked")
2627
static DatasetQuery fromMap(Map<String, Object> properties) {
2728
DatasetQuery query = new DatasetQuery();
2829
query.projectId = (String) properties.get("project_id");
@@ -31,12 +32,10 @@ static DatasetQuery fromMap(Map<String, Object> properties) {
3132
query.timezone = (String) properties.get("timezone");
3233
query.interval = (String) properties.get("interval");
3334
query.timeframe = (String) properties.get("timeframe");
34-
//noinspection unchecked
3535
query.groupBy = (List<String>) properties.get("group_by");
3636

3737
if (properties.get("filters") != null) {
3838
query.filters = new LinkedList<Filter>();
39-
//noinspection unchecked
4039
for (Map<String, Object> filter : (List<Map<String, Object>>) properties.get("filters")) {
4140
query.filters.add(new Filter(
4241
(String) filter.get("property_name"),

0 commit comments

Comments
 (0)