sort results from etcd so keys are always in the same order #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelseyhightower
added a commit
that referenced
this pull request
Aug 4, 2014
sort results from etcd so keys are always in the same order
|
@billhathaway Thanks for doing this! |
|
I just started using a list of keys for IP address restrictions and found that my proxy was restarting often because the keys kept being returned in different orders. Would love to get this fix into production. Can we expect a 0.6.0-alpha2 soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 107.
The problem this addresses is that the order of keys can change if they are expiring and being reset, even when they contain the same value. This change asks etcd to return the keys in a sorted order.