Set DialTimeout in etcd client #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on coreos/go-etcd#151. |
|
+1 Once the test pass. |
|
I just restarted the build. |
|
Ok once the upstream commit gets merged, then I'll pull this in. We need to be sure to add this to 0.6.x as well. |
|
@kelseyhightower My addition was merged upstream. |
|
Please rebase this on master, I've updated the deps. |
One second (the default) isn't long enough for many tasks.
|
@kelseyhightower Done. |
kelseyhightower
added a commit
that referenced
this pull request
Aug 8, 2014
Set DialTimeout in etcd client
carmstrong
added a commit
to carmstrong/confd
that referenced
this pull request
Oct 6, 2014
This re-implements kelseyhightower#112 for confd 0.6.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One second (the default) isn't long enough for many tasks.