fix(resource.go): try writing to destination when rename fails #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rerunning the tests now. Looks like an issue with travis CI. |
kelseyhightower
added a commit
that referenced
this pull request
Sep 2, 2014
fix(resource.go): try writing to destination when rename fails
|
@kelseyhightower It looks like we lost this in master.. it only exists in the 0.5.x branch. |
|
@carmstrong Oh no! I may have to add this patch on 0.6.x |
|
@carmstrong I had issues with the merge -- I hate long running branches :( Care to issue a PR for this? |
I'll try to fix this. In the meantime, you may want to look through merged PRs and see if we missed any others. |
carmstrong
added a commit
to carmstrong/confd
that referenced
this pull request
Oct 6, 2014
This was implemented for confd 0.5.x in kelseyhightower#123, but lost when the 0.6.x branch was made the new master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #122