build: ensure generated umd files are strict

Fdawgs · Fdawgs · commit da4568c8f44d · 2025-02-26T20:49:55.000Z
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -129,13 +129,13 @@
     "suffix-thumb": "5.0.2"
   },
   "devDependencies": {
-    "@rollup/plugin-node-resolve": "15.3.0",
+    "@rollup/plugin-node-resolve": "16.0.0",
     "@rollup/plugin-terser": "0.4.4",
     "cross-env": "^7.0.3",
     "eslint": "9.16.0",
     "eslint-plugin-regexp": "2.7.0",
     "nlp-corpus": "4.4.0",
-    "rollup": "4.28.0",
+    "rollup": "4.34.8",
     "rollup-plugin-filesize-check": "1.2.0",
     "shelljs": "0.8.5",
     "tap-dancer": "0.3.4",
diff --git a/plugins/_experiments/markdown/rollup.config.js b/plugins/_experiments/markdown/rollup.config.js
@@ -4,6 +4,7 @@ import { nodeResolve } from '@rollup/plugin-node-resolve';
 import commonjs from '@rollup/plugin-commonjs';
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   // {
@@ -14,7 +15,7 @@ export default [
   {
     input: 'src/plugin.js',
     output: [{ file: 'builds/compromise-markup.min.js', format: 'umd', name: 'compromiseMarkup' }],
-    plugins: [commonjs(), nodeResolve(), terser(opts), sizeCheck({ expect: 5, warn: 15 })],
+    plugins: [commonjs(), nodeResolve(), terser(umdOpts), sizeCheck({ expect: 5, warn: 15 })],
   },
   // {
   //   input: 'src/plugin.js',
diff --git a/plugins/dates/rollup.config.js b/plugins/dates/rollup.config.js
@@ -3,6 +3,7 @@ import sizeCheck from 'rollup-plugin-filesize-check'
 import { nodeResolve } from '@rollup/plugin-node-resolve';
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   {
@@ -13,7 +14,7 @@ export default [
   {
     input: 'src/plugin.js',
     output: [{ file: 'builds/compromise-dates.min.js', format: 'umd', name: 'compromiseDates' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 113, warn: 15 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 113, warn: 15 })],
   },
   {
     input: 'src/plugin.js',
diff --git a/plugins/paragraphs/rollup.config.js b/plugins/paragraphs/rollup.config.js
@@ -3,6 +3,7 @@ import sizeCheck from 'rollup-plugin-filesize-check'
 import { nodeResolve } from '@rollup/plugin-node-resolve';
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   {
@@ -13,7 +14,7 @@ export default [
   {
     input: 'src/plugin.js',
     output: [{ file: 'builds/compromise-paragraphs.min.js', format: 'umd', name: 'compromiseParagraphs' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 5, warn: 15 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 5, warn: 15 })],
   },
   {
     input: 'src/plugin.js',
diff --git a/plugins/payload/rollup.config.js b/plugins/payload/rollup.config.js
@@ -3,6 +3,7 @@ import sizeCheck from 'rollup-plugin-filesize-check'
 import { nodeResolve } from '@rollup/plugin-node-resolve'
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   {
@@ -13,7 +14,7 @@ export default [
   {
     input: 'src/plugin.js',
     output: [{ file: 'builds/compromise-payload.min.js', format: 'umd', name: 'compromisePayload' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 387, warn: 15 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 387, warn: 15 })],
   },
   {
     input: 'src/plugin.js',
diff --git a/plugins/speech/rollup.config.js b/plugins/speech/rollup.config.js
@@ -3,6 +3,7 @@ import sizeCheck from 'rollup-plugin-filesize-check'
 import { nodeResolve } from '@rollup/plugin-node-resolve';
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   {
@@ -13,7 +14,7 @@ export default [
   {
     input: 'src/plugin.js',
     output: [{ file: 'builds/compromise-speech.min.js', format: 'umd', name: 'compromiseSpeech' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 4, warn: 15 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 4, warn: 15 })],
   },
   {
     input: 'src/plugin.js',
diff --git a/plugins/speed/rollup.config.js b/plugins/speed/rollup.config.js
@@ -3,6 +3,7 @@ import sizeCheck from 'rollup-plugin-filesize-check'
 import { nodeResolve } from '@rollup/plugin-node-resolve';
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   {
@@ -13,7 +14,7 @@ export default [
   {
     input: 'src/plugin.js',
     output: [{ file: 'builds/compromise-speed.min.js', format: 'umd', name: 'compromiseSpeed' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 5, warn: 15 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 5, warn: 15 })],
   },
   {
     input: 'src/plugin.js',
diff --git a/plugins/stats/rollup.config.js b/plugins/stats/rollup.config.js
@@ -3,6 +3,7 @@ import sizeCheck from 'rollup-plugin-filesize-check'
 import { nodeResolve } from '@rollup/plugin-node-resolve';
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   {
@@ -13,7 +14,7 @@ export default [
   {
     input: 'src/plugin.js',
     output: [{ file: 'builds/compromise-stats.min.js', format: 'umd', name: 'compromiseStats' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 67, warn: 15 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 67, warn: 15 })],
   },
   {
     input: 'src/plugin.js',
diff --git a/plugins/wikipedia/rollup.config.js b/plugins/wikipedia/rollup.config.js
@@ -3,6 +3,7 @@ import sizeCheck from 'rollup-plugin-filesize-check'
 import { nodeResolve } from '@rollup/plugin-node-resolve';
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   {
@@ -13,7 +14,7 @@ export default [
   {
     input: 'src/plugin.js',
     output: [{ file: 'builds/compromise-wikipedia.min.js', format: 'umd', name: 'compromiseWikipedia' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 387, warn: 15 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 387, warn: 15 })],
   },
   {
     input: 'src/plugin.js',
diff --git a/rollup.config.js b/rollup.config.js
@@ -3,20 +3,21 @@ import { nodeResolve } from '@rollup/plugin-node-resolve'
 import sizeCheck from 'rollup-plugin-filesize-check'
 
 const opts = { keep_classnames: true, module: true }
+const umdOpts = { ...opts, module: false }
 
 export default [
   // === Main ==
   {
     input: 'src/three.js',
     output: [{ file: 'builds/compromise.js', format: 'umd', name: 'nlp' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 277, warn: 30 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 277, warn: 30 })],
   },
 
   // === One ==
   {
     input: 'src/one.js',
     output: [{ file: 'builds/one/compromise-one.cjs', format: 'umd', name: 'nlp' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 69, warn: 15 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 69, warn: 15 })],
   },
   {
     input: 'src/one.js',
@@ -28,7 +29,7 @@ export default [
   {
     input: 'src/two.js',
     output: [{ file: 'builds/two/compromise-two.cjs', format: 'umd', name: 'nlp' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 226, warn: 30 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 226, warn: 30 })],
   },
   {
     input: 'src/two.js',
@@ -40,7 +41,7 @@ export default [
   {
     input: 'src/three.js',
     output: [{ file: 'builds/three/compromise-three.cjs', format: 'umd', name: 'nlp' }],
-    plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 277, warn: 30 })],
+    plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 277, warn: 30 })],
   },
   {
     input: 'src/three.js',

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ import sizeCheck from 'rollup-plugin-filesize-check'`
`3`	`3`	`import { nodeResolve } from '@rollup/plugin-node-resolve';`
`4`	`4`
`5`	`5`	`const opts = { keep_classnames: true, module: true }`
	`6`	`+const umdOpts = { ...opts, module: false }`
`6`	`7`
`7`	`8`	`export default [`
`8`	`9`	`{`
`@@ -13,7 +14,7 @@ export default [`
`13`	`14`	`{`
`14`	`15`	`input: 'src/plugin.js',`
`15`	`16`	`output: [{ file: 'builds/compromise-dates.min.js', format: 'umd', name: 'compromiseDates' }],`
`16`		`- plugins: [nodeResolve(), terser(opts), sizeCheck({ expect: 113, warn: 15 })],`
	`17`	`+ plugins: [nodeResolve(), terser(umdOpts), sizeCheck({ expect: 113, warn: 15 })],`
`17`	`18`	`},`
`18`	`19`	`{`
`19`	`20`	`input: 'src/plugin.js',`