fix duplicate register when two or more modules loaded

Author: drswinghead

phpgo/extension.c

@@ -653,6 +653,11 @@ int zend_add_function(int cidx, int fidx, int cbid, char *name, char *atys, int
     printf("add func %s at %d:%d=%d, atys=%s, rety=%d\n",
            name, cidx, fidx, cbid, atys, rety);
 
+    // TODO 检测是否是phpgo注册的？
+    if (gozend_function_registered(name) == 1) {
+        dlog_debug("function already exists: %s", name);
+    }
+
     int cnlen = strlen(GLOBAL_VCLASS_NAME);
     char *cname = GLOBAL_VCLASS_NAME;
     char *mname = name;

phpgo/extension.go

@@ -3,6 +3,7 @@ package phpgo
 /*
 #include "extension.h"
 #include "../zend/compat.h"
+#include "../zend/szend.h"
 
 #include <php.h>
 #include <zend_exceptions.h>
@@ -19,9 +20,10 @@ import "errors"
 import "fmt"
 import "log"
 import "os"
-import "github.com/kitech/php-go/zend"
 import "strings"
 
+import "github.com/kitech/php-go/zend"
+
 // 一个程序只能创建一个扩展
 // 所以使用全局变量也没有问题。
 var (
@@ -336,11 +338,22 @@ func AddConstant(name string, val interface{}, namespace interface{}) {
 // 内置函数注册，内置类注册。
 func addBuiltins() {
 	// nice fix exit crash bug.
-	AddFunc("GoExit", func(code int) { os.Exit(code) })
-	AddFunc("GoGo", func(fn interface{}) { log.Println(fn) })
-	AddFunc("GoPanic", func() { panic("got") })
-	AddFunc("GoRecover", func() { recover() })
-	AddFunc("GoPrintln", func(p0 int, v interface{}) { log.Println(v, 123333) })
+	var iret C.int = 0
+	if iret = C.gozend_function_registered(C.CString("GoExit")); iret == C.int(0) {
+		AddFunc("GoExit", func(code int) { os.Exit(code) })
+	}
+	if iret = C.gozend_function_registered(C.CString("GoGo")); iret == C.int(0) {
+		AddFunc("GoGo", func(fn interface{}) { log.Println(fn) })
+	}
+	if iret = C.gozend_function_registered(C.CString("GoPanic")); iret == C.int(0) {
+		AddFunc("GoPanic", func() { panic("got") })
+	}
+	if iret = C.gozend_function_registered(C.CString("GoRecover")); iret == C.int(0) {
+		AddFunc("GoRecover", func() { recover() })
+	}
+	if iret = C.gozend_function_registered(C.CString("GoPrintln")); iret == C.int(0) {
+		AddFunc("GoPrintln", func(p0 int, v interface{}) { log.Println(v, 123333) })
+	}
 }
 
 // 注册php module 初始化函数

zend/szend.c

@@ -183,3 +183,44 @@ void call_user_function_callback(char *data)
     // zval_ptr_dtor(&retval_ptr);
     zval_dtor(&function_name);
 }
+
+// find function name in HashTable
+static int _gozend_function_exists_ht(char *fname, HashTable* ht) {
+	zend_string *name;
+	zend_function *func;
+	zend_string *lcname;
+
+    name = zend_string_init(fname, strlen(fname), 0);
+
+	if (ZSTR_VAL(name)[0] == '\\') {
+		/* Ignore leading "\" */
+		lcname = zend_string_alloc(ZSTR_LEN(name) - 1, 0);
+		zend_str_tolower_copy(ZSTR_VAL(lcname), ZSTR_VAL(name) + 1, ZSTR_LEN(name) - 1);
+	} else {
+		lcname = zend_string_tolower(name);
+	}
+
+	func = zend_hash_find_ptr(ht, lcname);
+	zend_string_release(lcname);
+    zend_string_release(name);
+
+	/*
+	 * A bit of a hack, but not a bad one: we see if the handler of the function
+	 * is actually one that displays "function is disabled" message.
+	 */
+	if (func && (func->type != ZEND_INTERNAL_FUNCTION ||
+                 func->internal_function.handler != zif_display_disabled_function)) {
+        return 1;
+    } else {
+        return 0;
+    }
+}
+
+// seems only can be used when vm executing
+int gozend_function_exists(char *fname) {
+    return _gozend_function_exists_ht(fname, executor_globals.function_table);
+}
+
+int gozend_function_registered(char *fname) {
+    return _gozend_function_exists_ht(fname, compiler_globals.function_table);
+}

zend/szend.h

@@ -14,5 +14,7 @@ extern void *gozend_ecalloc(size_t nmemb, size_t size);
 extern void *gozend_erealloc(void *ptr, size_t size);
 extern char gozend_eval_string(char *code);
 extern void call_user_function_callback(char *arg);
+extern int gozend_function_exists(char *fname);
+extern int gozend_function_registered(char *fname);
 
 #endif