Don't take curl callback by ref

ptarjan · ptarjan · commit 1a33bb8089a2 · 2014-05-14T17:27:58.000-07:00
Changing these does nothing to the caller, why would you take them by ref? HHVM doesn't promote this to refs if they can't be modified: facebook/hhvm#2587
diff --git a/S3.php b/S3.php
@@ -2307,7 +2307,7 @@ private function __dnsBucketName($bucket)
 	* @param string &$data Data
 	* @return integer
 	*/
-	private function __responseHeaderCallback(&$curl, &$data)
+	private function __responseHeaderCallback($curl, $data)
 	{
 		if (($strlen = strlen($data)) <= 2) return $strlen;
 		if (substr($data, 0, 4) == 'HTTP')

Original file line number	Diff line number	Diff line change
`@@ -2307,7 +2307,7 @@ private function __dnsBucketName($bucket)`
`2307`	`2307`	`* @param string &$data Data`
`2308`	`2308`	`* @return integer`
`2309`	`2309`	`*/`
`2310`		`- private function __responseHeaderCallback(&$curl, &$data)`
	`2310`	`+ private function __responseHeaderCallback($curl, $data)`
`2311`	`2311`	`{`
`2312`	`2312`	`if (($strlen = strlen($data)) <= 2) return $strlen;`
`2313`	`2313`	`if (substr($data, 0, 4) == 'HTTP')`