Skip to content

Conversation

@JaapWijnen
Copy link
Contributor

@JaapWijnen JaapWijnen commented Oct 27, 2016

@kelvinlauKL kelvinlauKL merged commit 2b61c06 into kodecocodes:master Nov 1, 2016
@kelvinlauKL
Copy link
Member

I've made a few changes on this:

To keep consistent with the other native Collection types, I've removed the argument labels for append.

removeAtIndex(index: Int) has also been changed to removeAt(index: Int) to avoid mentioning index twice.

Thanks!

@chris-pilcher chris-pilcher mentioned this pull request Nov 1, 2016
71 tasks
@JaapWijnen
Copy link
Contributor Author

Ah good point! I'll try to think of it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants