Migrated Huffman Coding to Swift 3 syntax #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinlauKL
reviewed
Jan 4, 2017
Member
kelvinlauKL
left a comment
kelvinlauKL
left a comment
There was a problem hiding this comment.
Looks fine other than a pair of overly verbose syntax. Thanks :)
| let s1 = "so much words wow many compression" | ||
| if let originalData = s1.dataUsingEncoding(NSUTF8StringEncoding) { | ||
| print(originalData.length) | ||
| if let originalData = s1.data(using: String.Encoding.utf8) { |
Member
There was a problem hiding this comment.
As per our style guidelines, you should shorten this to s1.data(using: .utf8).
| print(decompressedData.length) | ||
|
|
||
| let s2 = String(data: decompressedData, encoding: NSUTF8StringEncoding)! | ||
| let s2 = String(data: decompressedData as Data, encoding: String.Encoding.utf8)! |
Member
There was a problem hiding this comment.
Same as above: .utf8 rather than String.Encoding.utf8
This was referenced Jan 5, 2017
Member
|
Looks good, thanks @pbodsk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope I got this right 😄