Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubeflow/trainer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.0-rc.0
Choose a base ref
...
head repository: kubeflow/trainer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.0-rc.1
Choose a head ref
  • 4 commits
  • 7 files changed
  • 3 contributors

Commits on Sep 6, 2021

  1. Configuration menu
    Copy the full SHA
    1aa44a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. 2010: fix to expose correct monitoring port (#1405)

    * 1399: added pod matching label in service selector
    
    * correct fix
    
    * 2010: fix to expose correct monitoring port
    
    training-operator exposes 8080 per logs
    2021-09-14T19:31:49.294Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":8080"}
    hence when we do local testing, it works fine
    but when we expose it using make deploy then inside k8s, its not exposed
    
    * reverting fix from other fix-branch
    
    * now prometheus will scrape on 8080
    deepak-muley authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    2f78f8e View commit details
    Browse the repository at this point in the history
  2. Fix 1399: added pod matching label in service selector (#1404)

    * 1399: added pod matching label in service selector
    
    * correct fix
    deepak-muley authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    a1a0c18 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Configuration menu
    Copy the full SHA
    913d161 View commit details
    Browse the repository at this point in the history
Loading