Skip to content

Kubernetes 1.19 fixes #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Kubernetes 1.19 fixes #98

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b4a2f1
prow.sh: fix installing Go for Kubernetes 1.19.0
pohly Aug 14, 2020
0979c09
prow.sh: fix E2E suite for Kubernetes >= 1.18
pohly Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
prow.sh: fix installing Go for Kubernetes 1.19.0 
Kubernetes 1.19.0 uses Go 1.15, but refers to it as 1.15.0. This broke
both the check whether we need to install 1.15 (because "go version"
reports 1.15, which didn't match 1.15.0) and then downloading the
release archive (because the URL also only uses 1.15).
  • Loading branch information
@pohly
pohly committed Aug 14, 2020
commit 3b4a2f1d956845ab094e61d8701eab2080226cd3
4 changes: 4 additions & 0 deletions prow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,10 @@ go_version_for_kubernetes () (
if ! [ "$go_version" ]; then
die "Unable to determine Go version for Kubernetes $version from hack/lib/golang.sh."
fi
# Strip the trailing .0. Kubernetes includes it, Go itself doesn't.
# Ignore: See if you can use ${variable//search/replace} instead.
# shellcheck disable=SC2001
go_version="$(echo "$go_version" | sed -e 's/\.0$//')"
echo "$go_version"
)

Expand Down