Merge pull request #59 from msau42/deprecate

remove deprecated connection-timeout arg

Author: k8s-ci-robot

README.md

@@ -77,10 +77,6 @@ spec:
 
 * All glog / klog arguments are supported, such as `-v <log level>` or `-alsologtostderr`.
 
-#### Deprecated arguments
-
-* `--connection-timeout <duration>`: This option was used to limit establishing connection to CSI driver. Currently, the option does not have any effect and the external-provisioner tries to connect to CSI driver socket indefinitely. It is recommended to run ReadinessProbe on the driver to ensure that the driver comes up in reasonable time.
-
 ## Community, discussion, contribution, and support
 
 Learn how to engage with the Kubernetes community on the [community page](http://kubernetes.io/community/).

cmd/livenessprobe/main.go

@@ -26,7 +26,6 @@ import (
 	"k8s.io/klog"
 
 	connlib "github.com/kubernetes-csi/csi-lib-utils/connection"
-	"github.com/kubernetes-csi/csi-lib-utils/deprecatedflags"
 	"github.com/kubernetes-csi/csi-lib-utils/rpc"
 
 	"google.golang.org/grpc"
@@ -37,8 +36,6 @@ var (
 	probeTimeout = flag.Duration("probe-timeout", time.Second, "Probe timeout in seconds")
 	csiAddress   = flag.String("csi-address", "/run/csi/socket", "Address of the CSI driver socket.")
 	healthzPort  = flag.String("health-port", "9808", "TCP ports for listening healthz requests")
-
-	_ = deprecatedflags.Add("connection-timeout")
 )
 
 type healthProbe struct {

deployment/kubernetes/hostpath-with-livenessprobe.yaml

@@ -1,5 +1,5 @@
   - name: hostpath-driver
-    image: quay.io/k8scsi/hostpathplugin:v0.2.0
+    image: quay.io/k8scsi/hostpathplugin:canary
     imagePullPolicy: Always
     securityContext:
       privileged: true
@@ -47,9 +47,8 @@
     volumeMounts:
     - mountPath: /csi
       name: socket-dir
-    image: quay.io/k8scsi/livenessprobe:v0.2.0
+    image: quay.io/k8scsi/livenessprobe:canary
     args:
     - --v=5
     - --csi-address=/csi/csi.sock
-    - --connection-timeout=3s
 #

deployment/kubernetes/livenessprobe-sidecar.yaml

@@ -13,7 +13,6 @@ github.com/golang/protobuf/ptypes/timestamp
 github.com/golang/protobuf/ptypes/wrappers
 # github.com/kubernetes-csi/csi-lib-utils v0.6.1
 github.com/kubernetes-csi/csi-lib-utils/connection
-github.com/kubernetes-csi/csi-lib-utils/deprecatedflags
 github.com/kubernetes-csi/csi-lib-utils/protosanitizer
 github.com/kubernetes-csi/csi-lib-utils/rpc
 # github.com/kubernetes-csi/csi-test v2.0.0+incompatible