Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.16.4
Choose a base ref
...
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.16.5
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Feb 15, 2024

  1. Fix lazy rest mapper cache invalidation 

    When a group version is not found, if the group version is cached in
apiGroups but not cached in knownGroups, the cache is not invalidated.
Moreover and even worse, in that scenario an error is returned.

This is only an issue under the very rare case where a version has been
removed during a call just after caching in apiGroups but before it's
cached in knownGroups.

After the change now an error is never returned for not found versions
no matter if the version was cached or not. And now the two different
caches are checked and invalidated independently.
    @g-gaston
    g-gaston committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    df3a90a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2689 from g-gaston/fix-cache-invalidation-for-uns… 

    …ync-caches-backport-0-16

[release-0.16] 🐛 Fix lazy rest mapper cache invalidation
    @k8s-ci-robot
    k8s-ci-robot authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    dca5e8b View commit details
    Browse the repository at this point in the history
Loading