Skip to content

🌱 Return the error from rest.HTTPClientFor instead of hiding it #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2023
Merged

🌱 Return the error from rest.HTTPClientFor instead of hiding it #2161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
return an error that wraps the original error 
Signed-off-by: Tim Ramlot <[email protected]>
  • Loading branch information
@inteon
inteon committed Jan 31, 2023
commit e3143ac017a18ba61b4fdea5888903af1ba60743
4 changes: 2 additions & 2 deletions pkg/cache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ func defaultOpts(config *rest.Config, opts Options) (Options, error) {
opts.HTTPClient, err = rest.HTTPClientFor(config)
if err != nil {
logger.Error(err, "Failed to get HTTP client")
return opts, fmt.Errorf("could not create HTTP client from config")
return opts, fmt.Errorf("could not create HTTP client from config: %w", err)
}
}

Expand All @@ -442,7 +442,7 @@ func defaultOpts(config *rest.Config, opts Options) (Options, error) {
opts.Mapper, err = apiutil.NewDiscoveryRESTMapper(config, opts.HTTPClient)
if err != nil {
logger.Error(err, "Failed to get API Group-Resources")
return opts, fmt.Errorf("could not create RESTMapper from config")
return opts, fmt.Errorf("could not create RESTMapper from config: %w", err)
}
}

Expand Down