Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
✨ add new extension to markers in order to allow work with .yml
  • Loading branch information
camilamacedo86 committed Dec 15, 2020
commit 7dc4d333c8804071b32cbc1abfabe81861749c73
5 changes: 3 additions & 2 deletions pkg/model/file/marker.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ var commentsByExt = map[string]string{
// this is a backwards incompatible change, and thus should be done for next project version.
".go": "// ",
".yaml": "# ",
".yml": "#",
// When adding additional file extensions, update also the NewMarkerFor documentation and error
}

Expand All @@ -38,14 +39,14 @@ type Marker struct {
}

// NewMarkerFor creates a new marker customized for the specific file
// Supported file extensions: .go, .ext
// Supported file extensions: .go, .yaml, .yml
func NewMarkerFor(path string, value string) Marker {
ext := filepath.Ext(path)
if comment, found := commentsByExt[ext]; found {
return Marker{comment, value}
}

panic(fmt.Errorf("unknown file extension: '%s', expected '.go' or '.yaml'", ext))
panic(fmt.Errorf("unknown file extension: '%s', expected '.go', '.yaml' or '.yml'", ext))
}

// String implements Stringer
Expand Down