Skip to content

📖 update redirects for v3.0.0 #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2021
Merged

📖 update redirects for v3.0.0 #2062

merged 1 commit into from
Mar 8, 2021

Conversation

@estroz
Copy link
Contributor

@estroz estroz commented Mar 4, 2021

  • netlify.toml: update redirects for v3.0.0
  • docs/book/src: update https://go.kubebuilder.io links to match new redirects and download instructions

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 4, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2021
@estroz estroz marked this pull request as ready for review March 4, 2021 23:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2021
@estroz estroz changed the title :book.: update redirects for v3.0.0 📖 update redirects for v3.0.0 Mar 4, 2021
Adirio
Adirio suggested changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definetely move forward with this as it has been asked in Slack recently, some comments:

@estroz
netlify.toml: update redirects for v3.0.0
bc7ce7d 
docs/book/src: update https://go.kubebuilder.io links to match
new redirects

Signed-off-by: Eric Stroczynski <[email protected]>
@estroz estroz force-pushed the docs/update-redirects branch from 32dede9 to bc7ce7d Compare March 5, 2021 06:55
@Adirio
Copy link
Contributor

Adirio commented Mar 5, 2021

/lgtm
/hold

Holding until e2e tests are passed (#2063), feel free to remove the hold afterwards

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@estroz
Copy link
Contributor Author

estroz commented Mar 5, 2021

/retest

@Adirio
Copy link
Contributor

Adirio commented Mar 5, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2021
@camilamacedo86
Copy link
Member

camilamacedo86 commented Mar 6, 2021 •
edited
Loading

/retest

@camilamacedo86 camilamacedo86 reopened this Mar 6, 2021
@Adirio
Copy link
Contributor

Adirio commented Mar 7, 2021

NOTE: right now latest points to v2.3.2 (as v3.0.0-xxxxx have been marked as pre-releases). But once this gets into the actual book, there is going to be a v3.0.0 release which wil be where latest points to, so keeping latest is fine.

@camilamacedo86
Copy link
Member

camilamacedo86 commented Mar 8, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 8, 2021 •
edited
Loading

@estroz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-e2e-k8s-1-17-11 bc7ce7d link /test pull-kubebuilder-e2e-k8s-1-17-11

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 984816b into kubernetes-sigs:master Mar 8, 2021
@estroz estroz deleted the docs/update-redirects branch March 8, 2021 18:28
@DirectXMan12 DirectXMan12 mentioned this pull request Apr 29, 2021
Merged
@devinleee devinleee mentioned this pull request Jul 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

1 more reviewer

@Adirio Adirio Adirio requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Adirio Adirio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estroz @k8s-ci-robot @Adirio @camilamacedo86