controller: fix module imports #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller.test binary and the example still imported without the /v5 suffix. This resulted in spurious "sigs.k8s.io/sig-storage-lib-external-provisioner v4.1.0+incompatible // indirect" go.mod entries in projects using the lib (kubernetes-csi/external-provisioner#405 (comment)). The example needs to use the sources that it was checked out with. Otherwise it is impossible to change the API and the example in a single commit and/or there is a risk that breaking changes go undetected because the example continues to build with the unmodified lib.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
xing-yang
reviewed
Apr 1, 2020
| sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0 | ||
| ) | ||
|
|
||
| replace sigs.k8s.io/sig-storage-lib-external-provisioner/v5 => ../.. |
Contributor
Author
There was a problem hiding this comment.
Without it, "make" in examples/hostpath-provisioner will use the latest published release of sigs.k8s.io/sig-storage-lib-external-provisioner/v5 instead of the current source code.
Now consider what happens when a breaking API change is made:
- first the current implementation of the lib gets updated
- a new release must be tagged which contains an example that still uses the old API
- only now can the example be updated
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
humblec
pushed a commit
to humblec/sig-storage-lib-external-provisioner
that referenced
this pull request
Jun 18, 2020
Change 'make test-vet' back to call 'go vet'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller.test binary and the example still imported without the
/v5 suffix. This resulted in spurious
"sigs.k8s.io/sig-storage-lib-external-provisioner v4.1.0+incompatible
// indirect" go.mod entries in projects using the
lib (kubernetes-csi/external-provisioner#405 (comment)).
The example needs to use the sources that it was checked out
with. Otherwise it is impossible to change the API and the example in
a single commit and/or there is a risk that breaking changes go
undetected because the example continues to build with the unmodified
lib.