Unknown-fields fixes - Cleanup

[asim-reza]

Issue

Unknown field checks are not enabled for ProwJob configuration. #26368

Description

Prow's checkconfig tool is responsible for presubmit validation of ProwJob configuration. It has an optional check for unknown fields in ProwJob config that can be enabled with --warnings=unknown-fields-all. We currently do not have this check enabled.
As a result it is possible to add configuration that is not recognized by Prow, causing it to be silently ignored. Common examples of this are typos in a field name and incorrect indentation.

What was done

All errors in the configs were fixed (of which there were alot) ....

docker run -i --rm -v "${PWD}:${PWD}" -w "${PWD}" gcr.io/k8s-prow/checkconfig:v20220905-8bcebc6376 --config-path=config/prow/config.yaml --job-config-path=config/jobs --plugin-config=config/prow/plugins.yaml --strict --warnings=mismatched-tide-lenient --warnings=tide-strict-branch --warnings=needs-ok-to-test --warnings=validate-owners --warnings=missing-trigger --warnings=validate-urls --warnings=unknown-fields --warnings=duplicate-job-refs --warnings=unknown-fields-all

was used to perform the tests

[k8s-ci-robot]

Hi @asim-reza. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @asim-reza!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[asim-reza]

@cjwagner @alexander-demichev @aramase

There were 2 errors I didnt know what to do about
1- "msg":"deprecated field: maintainers_id is configured for repo_milestone, maintainers_team should be used instead" <--- wasnt sure about the scope of this and what to change to.... and wasnt sure if I could just remove the maintainers_id and it would be assigned automatically

2- "msg":"error unmarshaling config/jobs/kubernetes/sig-cloud-provider/gcp/registry/default.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field \"buildImageRegistry\" <---- This is a file that has a list of values set in the env.... the file isn't a config file so maybe there should be a way to ommit some files from the check... if there is I wasnt sure how to

[asim-reza]

@cjwagner @alexander-demichev @aramase

There were 2 errors I didnt know what to do about 1- "msg":"deprecated field: maintainers_id is configured for repo_milestone, maintainers_team should be used instead" <--- wasnt sure about the scope of this and what to change to.... and wasnt sure if I could just remove the maintainers_id and it would be assigned automatically

2- "msg":"error unmarshaling config/jobs/kubernetes/sig-cloud-provider/gcp/registry/default.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field \"buildImageRegistry\" <---- This is a file that has a list of values set in the env.... the file isn't a config file so maybe there should be a way to ommit some files from the check... if there is I wasnt sure how to

If someone can point me to how to fix these 2 I'll get right on it and that should fix all of the errors!!
-Cheers

[asim-reza]

@cjwagner @alexander-demichev @aramase

-P.S sorry for the XXL size 😆

[matthyx]

/ok-to-test

[asim-reza]

/test pull-test-infra-verify-lint

[asim-reza]

all unknown field errors fixed 🎊 🎊 🎊 🎊 🎊
{"component":"checkconfig","file":"k8s.io/test-infra/prow/cmd/checkconfig/main.go:252","func":"main.main","level":"info","msg":"checkconfig passes without any error!","severity":"info","time":"2022-09-06T12:52:47Z"}

the config/jobs/kubernetes/sig-cloud-provider/gcp/registry/default.yaml was changed to config/jobs/kubernetes/sig-cloud-provider/gcp/registry/default.txt as it was being read raw anyways and was passed to an environment variable

and the maintainers_id was commented out of
repo_milestone

[chaodaiG]

Please create a separate PR that adds a duplicate of pull-test-infra-prow-checkconfig, configure the duplicate optional: true, always_run: false, and add --warnings=unknown-fields-all, so that this PR can be validated by Prow

[asim-reza]

@chaodaiG

Please create a separate PR that adds a duplicate of pull-test-infra-prow-checkconfig, configure the duplicate optional: true, always_run: false, and add --warnings=unknown-fields-all, so that this PR can be validated by Prow

The PR is created #27389 ... Should I close this one?

[chaodaiG]

@chaodaiG

Please create a separate PR that adds a duplicate of pull-test-infra-prow-checkconfig, configure the duplicate optional: true, always_run: false, and add --warnings=unknown-fields-all, so that this PR can be validated by Prow

The PR is created #27389 ... Should I close this one?

no, #27389 should not be created on top of this PR, create it base off of master branch, and duplicate the config checking job instead of modifying it in place, I'll leave comment there

[chaodaiG]

cool https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/27386/pull-test-infra-prow-checkconfig-beta/1567272984492642304

[chaodaiG]

/label tide/merge-method-squash

[asim-reza]

Need help with this unit test fail.., I have combed through my changes over and over again... cant find whats causing it

[asim-reza]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asim-reza
Once this PR has been reviewed and has the lgtm label, please assign cpanato, spiffxp for approval by writing /assign @cpanato, spiffxp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• config/OWNERS
• config/jobs/kubernetes/sig-k8s-infra/trusted/releng/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[asim-reza]

/test pull-test-infra-unit-test

[k8s-ci-robot]

@asim-reza: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-test-infra-unit-test	4e4c6f2	link	true	/test pull-test-infra-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[asim-reza]

Unit test wouldnt resolve so created a clean PR