-
Notifications
You must be signed in to change notification settings - Fork 2.8k
kubebuilder presubmits use go 1.19 #27395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @oscr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/test pull-test-infra-prow-checkconfig-beta |
|
/test pull-test-infra-prow-checkconfig-beta Looks like the job is broken > https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-test-infra-prow-checkconfig-beta The job is bascially only green on: #27386 |
|
/test pull-test-infra-prow-checkconfig-beta |
|
@camilamacedo86 Just fyi. This job is failing everywhere right now, but it is an optional job. So if this PR has lgtm/approve it would merge. /lgtm |
|
/test pull-test-infra-prow-checkconfig-beta |
1 similar comment
|
/test pull-test-infra-prow-checkconfig-beta |
|
@oscr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approved
But we might need to wait until they fix the test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, oscr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@oscr: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update kubebuilder presubmits to use go 1.19
cc @camilamacedo86 @sbueringer
Related pr: kubernetes-sigs/kubebuilder#2911