Skip to content

Conversation

@oscr
Copy link
Contributor

@oscr oscr commented Sep 6, 2022

Update kubebuilder presubmits to use go 1.19

cc @camilamacedo86 @sbueringer

Related pr: kubernetes-sigs/kubebuilder#2911

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @oscr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 6, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2022
@camilamacedo86
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2022
@camilamacedo86
Copy link
Contributor

/test pull-test-infra-prow-checkconfig-beta

@sbueringer
Copy link
Member

sbueringer commented Sep 7, 2022

/test pull-test-infra-prow-checkconfig-beta

Looks like the job is broken > https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-test-infra-prow-checkconfig-beta

The job is bascially only green on: #27386
So I assume we need the fixes in this PR which are now in this PR #27400 (if I understood it correctly)

@oscr
Copy link
Contributor Author

oscr commented Sep 7, 2022

/test pull-test-infra-prow-checkconfig-beta

@sbueringer
Copy link
Member

@camilamacedo86 Just fyi. This job is failing everywhere right now, but it is an optional job. So if this PR has lgtm/approve it would merge.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@camilamacedo86
Copy link
Contributor

/test pull-test-infra-prow-checkconfig-beta

1 similar comment
@oscr
Copy link
Contributor Author

oscr commented Sep 10, 2022

/test pull-test-infra-prow-checkconfig-beta

@k8s-ci-robot
Copy link
Contributor

@oscr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-prow-checkconfig-beta bfb0dc4 link false /test pull-test-infra-prow-checkconfig-beta

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

But we might need to wait until they fix the test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, oscr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit f31ab34 into kubernetes:master Sep 10, 2022
@k8s-ci-robot
Copy link
Contributor

@oscr: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubebuilder-presubmits.yaml using file config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml

In response to this:

Update kubebuilder presubmits to use go 1.19

cc @camilamacedo86 @sbueringer

Related pr: kubernetes-sigs/kubebuilder#2911

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oscr oscr deleted the kubebuilder-go-1.19 branch September 11, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants