Address review: use DisposableObject for test cleanup, copy UV tiling in fallback path

- Use DisposableObject to dispose generated Materials/Textures in test finally
  blocks to prevent native-object leaks (LilToonToonStandardGeneratorTests,
  LilToonToonLitGeneratorTests)
- Copy mainTextureScale/mainTextureOffset in ToonStandardGenerator's
  non-IToonStandardConvertable fallback path for consistent UV tiling behavior

Co-authored-by: kurotu <74851548+kurotu@users.noreply.github.com>

Author: Copilot

Assets/VRCQuestTools-Tests/Editor/Models/MaterialGenerators/LilToonToonLitGeneratorTests.cs

@@ -71,6 +71,7 @@ public void ConvertToToonLit_NonBake_PreservesMainTextureScaleAndOffset()
             }
             finally
             {
+                using (DisposableObject.New(resultMat)) { }
                 Object.DestroyImmediate(sourceMaterial);
             }
         }
@@ -126,6 +127,7 @@ public void ConvertToToonLit_NonBake_PreservesDefaultMainTextureST()
             }
             finally
             {
+                using (DisposableObject.New(resultMat)) { }
                 Object.DestroyImmediate(sourceMaterial);
             }
         }
@@ -197,6 +199,8 @@ public void ConvertToToonLit_WithBake_PreservesMainTextureScaleAndOffset()
             }
             finally
             {
+                using (DisposableObject.New(resultMat?.mainTexture)) { }
+                using (DisposableObject.New(resultMat)) { }
                 Object.DestroyImmediate(sourceMaterial);
             }
         }
@@ -290,6 +294,10 @@ public void ConvertToToonLit_WithBake_BakedTextureDoesNotEmbedUVTiling()
             }
             finally
             {
+                using (DisposableObject.New(resultMat11?.mainTexture)) { }
+                using (DisposableObject.New(resultMat11)) { }
+                using (DisposableObject.New(resultMat22?.mainTexture)) { }
+                using (DisposableObject.New(resultMat22)) { }
                 Object.DestroyImmediate(mat11);
                 Object.DestroyImmediate(mat22);
             }
@@ -397,6 +405,10 @@ public void ConvertToToonLit_WithBake_EmissionUVIsAdjustedRelativeToMainUV()
             }
             finally
             {
+                using (DisposableObject.New(resultMat1?.mainTexture)) { }
+                using (DisposableObject.New(resultMat1)) { }
+                using (DisposableObject.New(resultMat2?.mainTexture)) { }
+                using (DisposableObject.New(resultMat2)) { }
                 Object.DestroyImmediate(mat1);
                 Object.DestroyImmediate(mat2);
             }

Assets/VRCQuestTools-Tests/Editor/Models/MaterialGenerators/LilToonToonStandardGeneratorTests.cs

@@ -160,6 +160,7 @@ public void ConvertToToonStandard_PreservesMainTextureScaleAndOffset()
             }
             finally
             {
+                using (DisposableObject.New(resultMat)) { }
                 Object.DestroyImmediate(sourceMaterial);
             }
         }
@@ -224,6 +225,7 @@ public void ConvertToToonStandard_PreservesDefaultUV()
             }
             finally
             {
+                using (DisposableObject.New(resultMat)) { }
                 Object.DestroyImmediate(sourceMaterial);
             }
         }
@@ -296,6 +298,8 @@ public void GenerateMaterial_WithBake_PreservesMainTextureST()
             }
             finally
             {
+                using (DisposableObject.New(resultMat?.mainTexture)) { }
+                using (DisposableObject.New(resultMat)) { }
                 Object.DestroyImmediate(dummyTexture);
                 Object.DestroyImmediate(sourceMaterial);
             }
@@ -498,6 +502,7 @@ public void ConvertToToonStandard_PreservesEmissionMapST_WhenDifferentFromMainUV
             }
             finally
             {
+                using (DisposableObject.New(resultMat)) { }
                 Object.DestroyImmediate(sourceMaterial);
             }
         }
@@ -574,6 +579,8 @@ public void LilToonMaterial_GenerateToonLitImage_MainUVTilingDoesNotAffectBakedO
             }
             finally
             {
+                using (DisposableObject.New(result11)) { }
+                using (DisposableObject.New(result22)) { }
                 Object.DestroyImmediate(mat11);
                 Object.DestroyImmediate(mat22);
             }
@@ -680,6 +687,10 @@ public void GenerateMaterial_WithBake_ToonStandardBakesTextureWithoutUVTiling()
             }
             finally
             {
+                using (DisposableObject.New(resultMat11?.mainTexture)) { }
+                using (DisposableObject.New(resultMat11)) { }
+                using (DisposableObject.New(resultMat22?.mainTexture)) { }
+                using (DisposableObject.New(resultMat22)) { }
                 Object.DestroyImmediate(mat11);
                 Object.DestroyImmediate(mat22);
             }
@@ -757,6 +768,7 @@ public void ConvertToToonStandard_PreservesOcclusionMapST()
             }
             finally
             {
+                using (DisposableObject.New(resultMat)) { }
                 Object.DestroyImmediate(sourceMaterial);
             }
         }

Packages/com.github.kurotu.vrc-quest-tools/Editor/Models/MaterialGenerators/ToonStandardGenerator.cs

@@ -143,6 +143,8 @@ public AsyncCallbackRequest GenerateMaterial(MaterialBase material, UnityEditor.
                     var newMaterial = new ToonStandardMaterialWrapper();
                     newMaterial.Name = material.Material.name;
                     newMaterial.MainTexture = newMat.mainTexture;
+                    newMaterial.MainTextureScale = newMat.mainTextureScale;
+                    newMaterial.MainTextureOffset = newMat.mainTextureOffset;
                     newMaterial.ShadowRamp = Settings.fallbackShadowRamp;
                     completion?.Invoke(newMaterial);
                 });