Skip to content

Commit bc7baf6

Browse files
committed
Added armv7s slice for AppStore compatability when publishing arm64 Apps
1 parent 675ef78 commit bc7baf6

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9022,28 +9022,36 @@
90229022
isa = XCBuildConfiguration;
90239023
baseConfigurationReference = 10EAA6FF1889E6B300DEB161 /* JavaScriptCore-iOS-Static.xcconfig */;
90249024
buildSettings = {
9025+
ARCHS = "$(ARCHS_STANDARD_INCLUDING_64_BIT)";
9026+
VALID_ARCHS = "arm64 armv7 i386 armv7s";
90259027
};
90269028
name = Debug;
90279029
};
90289030
10D592F11889C3DF00C05A0D /* Release */ = {
90299031
isa = XCBuildConfiguration;
90309032
baseConfigurationReference = 10EAA6FF1889E6B300DEB161 /* JavaScriptCore-iOS-Static.xcconfig */;
90319033
buildSettings = {
9034+
ARCHS = "$(ARCHS_STANDARD_INCLUDING_64_BIT)";
9035+
VALID_ARCHS = "arm64 armv7 i386 armv7s";
90329036
};
90339037
name = Release;
90349038
};
90359039
10D592F21889C3DF00C05A0D /* Profiling */ = {
90369040
isa = XCBuildConfiguration;
90379041
baseConfigurationReference = 10EAA6FF1889E6B300DEB161 /* JavaScriptCore-iOS-Static.xcconfig */;
90389042
buildSettings = {
9043+
ARCHS = "$(ARCHS_STANDARD_INCLUDING_64_BIT)";
9044+
VALID_ARCHS = "arm64 armv7 i386 armv7s";
90399045
};
90409046
name = Profiling;
90419047
};
90429048
10D592F31889C3DF00C05A0D /* Production */ = {
90439049
isa = XCBuildConfiguration;
90449050
baseConfigurationReference = 10EAA6FF1889E6B300DEB161 /* JavaScriptCore-iOS-Static.xcconfig */;
90459051
buildSettings = {
9052+
ARCHS = "$(ARCHS_STANDARD_INCLUDING_64_BIT)";
90469053
BUILD_VARIANTS = normal;
9054+
VALID_ARCHS = "arm64 armv7 i386 armv7s";
90479055
};
90489056
name = Production;
90499057
};

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ The JavaScriptCore library is part of the [WebKit project](http://www.webkit.org
44

55
This repo aims to re-produce the missing iOS targets while staying on a somewhat up-to-date version.
66

7-
Currently, the [Safari-538.12.1 tag](https://svn.webkit.org/repository/webkit/tags/Safari-538.12.1/) is used as the basis. With the current settings, the WTF and JavaScriptCore libraries can be compiled for armv7, arm64 and x86 (for the iOS simulator). It will be compiled without Unicode collation support, because Apple claims [ICU](http://site.icu-project.org/) is a private framework on iOS. It should be AppStore compatible this way.
7+
Currently, the [Safari-538.12.1 tag](https://svn.webkit.org/repository/webkit/tags/Safari-538.12.1/) is used as the basis. With the current settings, the WTF and JavaScriptCore libraries can be compiled for armv7, armv7s, arm64 and x86 (for the iOS simulator). It will be compiled without Unicode collation support, because Apple claims [ICU](http://site.icu-project.org/) is a private framework on iOS. It should be AppStore compatible this way.
88

99
This version of JSC deprecates the `typed-arrays` branch of this repository. JSC now supports Typed Arrays natively, without any hacks.
1010

0 commit comments

Comments
 (0)