chore: work without gcp creds (#1397)

Author: tmilos77

pkg/kcp/provider/gcp/client/gcpClients.go

@@ -37,6 +37,11 @@ type VpcPeeringClients struct {
 }
 
 func NewGcpClients(ctx context.Context, saJsonKeyPath string, vpcPeeringSaJsonKeyPath string, logger logr.Logger) (*GcpClients, error) {
+	if saJsonKeyPath == "" || saJsonKeyPath == "none" || vpcPeeringSaJsonKeyPath == "" || vpcPeeringSaJsonKeyPath == "none" {
+		logger.Info("Creating GCP clients stub since no GCP credentials provided")
+		return &GcpClients{}, nil
+	}
+
 	logger.
 		WithValues("saJsonKeyPath", saJsonKeyPath).
 		WithValues("vpcPeeringSaJsonKeyPath", vpcPeeringSaJsonKeyPath).

pkg/kcp/provider/gcp/client/gcpClients_test.go

@@ -0,0 +1,13 @@
+package client
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_GcpClientsCanCloseOnNilClients(t *testing.T) {
+	gcpClients := &GcpClients{}
+	err := gcpClients.Close()
+	assert.NoError(t, err)
+}