Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
135 commits
Select commit Hold shift + click to select a range
c4105ee
Made it so that it writes stts for default
fedacking Sep 17, 2025
87cfc01
format
fedacking Sep 17, 2025
b7f29e7
Update utils.rs
fedacking Sep 17, 2025
72f00b7
compare
fedacking Sep 17, 2025
999115d
moved function outside
fedacking Sep 17, 2025
2384772
Update sync.rs
fedacking Sep 17, 2025
ae963c8
Update Cargo.toml
fedacking Sep 17, 2025
b60cd75
Update Cargo.toml
fedacking Sep 17, 2025
29c4b4c
Update sync.rs
fedacking Sep 17, 2025
287da4e
Sorted trie
fedacking Sep 18, 2025
dded7b7
Compiles
fedacking Sep 18, 2025
1dc3e74
dedup
fedacking Sep 18, 2025
500be72
Update Cargo.toml
fedacking Sep 18, 2025
5a49a83
Update sync.rs
fedacking Sep 18, 2025
79b6795
par iter
fedacking Sep 18, 2025
278da8a
Update sync.rs
fedacking Sep 18, 2025
b9e0f83
Merge remote-tracking branch 'origin/main' into perf/fast-insert-snap
fedacking Sep 19, 2025
90f0752
Fixed compile
fedacking Sep 22, 2025
0a38b20
added logging for error
fedacking Sep 23, 2025
85cd817
Fixed edge case and pushed fix
fedacking Sep 23, 2025
211a6b6
print the account with an error
fedacking Sep 23, 2025
141019c
what's going on
fedacking Sep 23, 2025
6fa1883
Fix attempt
fedacking Sep 23, 2025
20b1a7c
Update sync.rs
fedacking Sep 23, 2025
0126919
Update trie_sorted.rs
fedacking Sep 23, 2025
33f750a
Added inc
fedacking Sep 23, 2025
34eebd1
rocksdb iterator
fedacking Sep 23, 2025
80557ad
fixed bytecodes
fedacking Sep 23, 2025
dc8d0ec
returned par iter
fedacking Sep 23, 2025
4298c21
added logging
fedacking Sep 24, 2025
74f2e5a
Scoped thread
fedacking Sep 24, 2025
46bb452
Removed logging
fedacking Sep 24, 2025
5a5d9a0
Don't spawn that many threads
fedacking Sep 24, 2025
0e53046
Improved error handling
fedacking Sep 24, 2025
8add39d
Fixed race condition
fedacking Sep 24, 2025
edc2f91
perf(l1): use BTree for tracking storages during snap sync
Oppen Sep 24, 2025
df2811d
fast put batch
fedacking Sep 24, 2025
13d6659
Update rocksdb.rs
fedacking Sep 24, 2025
8896db3
threadpool
fedacking Sep 24, 2025
86869ec
perf(l1): compress storage trie downloads
Oppen Sep 25, 2025
2ec688b
fix order
Oppen Sep 25, 2025
f0d1e0e
fix insertion
Oppen Sep 25, 2025
bccc632
Back into par iter
fedacking Sep 25, 2025
f7a4702
fix typo + time roots
Oppen Sep 25, 2025
9ea9ddf
extra data + reuse storages
Oppen Sep 25, 2025
e66cd62
Make lint
fedacking Sep 25, 2025
6756108
Merge remote-tracking branch 'origin/main' into perf/fast-insert-snap
fedacking Sep 25, 2025
37c1d79
Update db.rs
fedacking Sep 25, 2025
9473681
Merge remote-tracking branch 'origin/main' into perf/fast-insert-snap
fedacking Sep 25, 2025
6c8e0fb
WIP: scoped thread pool
pablodeymo Sep 25, 2025
2ebcafa
Finished scoped threadpool
fedacking Sep 25, 2025
677bf5c
Merge remote-tracking branch 'origin/thread_pool' into perf/fast-inse…
fedacking Sep 25, 2025
d650922
Adopted thread pool
fedacking Sep 25, 2025
6718148
Pool arc
fedacking Sep 25, 2025
c301529
Update sync.rs
fedacking Sep 25, 2025
8b5e934
naming threads
fedacking Sep 25, 2025
aa6fdbe
Update sync.rs
fedacking Sep 25, 2025
53b8163
Executed separatedly last task
fedacking Sep 25, 2025
8e704cc
Added crossbeam
fedacking Sep 26, 2025
ab9df8b
Merged the snap sync optimizations that improve storage leaves downlo…
jrchatruc Sep 26, 2025
af4c4e4
2 pools
fedacking Sep 26, 2025
888472a
Comment out debug! on insertion for now
jrchatruc Sep 26, 2025
b75034f
Testing priority queue
fedacking Sep 26, 2025
a7e2084
Add TODO
jrchatruc Sep 26, 2025
08fbdf6
Update sync.rs
fedacking Sep 26, 2025
07b8ea5
Update sync.rs
fedacking Sep 26, 2025
5795636
Merge branch 'perf/fast-insert-snap-pool' into merge_optimizations_fa…
fedacking Sep 26, 2025
ec81b86
Compiles
fedacking Sep 26, 2025
7a7e0f3
Update sync.rs
fedacking Sep 26, 2025
4e3621b
Simple semaphore
fedacking Sep 26, 2025
193327d
Update sync.rs
fedacking Sep 26, 2025
fa9ac95
Changed to fixed amount of buffers
fedacking Sep 29, 2025
e0ec836
Removed unneeded compaction
fedacking Sep 29, 2025
c93aa46
cleanup
fedacking Sep 29, 2025
9680d09
Merge remote-tracking branch 'origin/main' into merge_optimizations_f…
fedacking Sep 29, 2025
303f9e0
Compiles
fedacking Sep 29, 2025
adaf0b0
fixed tomls
fedacking Sep 29, 2025
1e0910a
Update code_collector.rs
fedacking Sep 30, 2025
ac7a8b9
Update rocksdb.rs
fedacking Sep 30, 2025
6d0e8d8
Removed unnecesaty alloc in put_batch_no_alloc
fedacking Sep 30, 2025
ca3942a
Removed cfg_if
fedacking Sep 30, 2025
ebcccd6
Update db.rs
fedacking Sep 30, 2025
f47bcb3
Fixed buffer count
fedacking Sep 30, 2025
60b9372
Update trie_sorted.rs
fedacking Sep 30, 2025
2c79fe0
Update sync.rs
fedacking Sep 30, 2025
7a14f42
Optimized insertion to disk
fedacking Sep 30, 2025
c02f069
fixed potential bug
fedacking Sep 30, 2025
60f0bc6
added debug logging
fedacking Sep 30, 2025
4528ac0
Update utils.rs
fedacking Sep 30, 2025
c8c00bc
fix
fedacking Sep 30, 2025
939ac99
Lint
fedacking Sep 30, 2025
dda32e4
Cleaned up code
fedacking Sep 30, 2025
fd55d47
Update Cargo.lock
fedacking Sep 30, 2025
558c5f0
simplified
fedacking Sep 30, 2025
3bf7b01
Lowered memory usage further (hopefully)
fedacking Sep 30, 2025
a659670
Update Cargo.lock
fedacking Sep 30, 2025
b9c0138
Perf changelog
fedacking Sep 30, 2025
21cef0a
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Sep 30, 2025
01f10bf
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 1, 2025
1886bf0
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 1, 2025
c079384
Remove comments and commented code
jrchatruc Oct 1, 2025
a497870
Update crates/networking/p2p/peer_handler.rs
jrchatruc Oct 1, 2025
31652d8
Update CHANGELOG.md
jrchatruc Oct 1, 2025
bbbb137
initial chunk test
rodrigo-o Oct 1, 2025
a1397ad
reduce trie sorted size to write and buffer count
rodrigo-o Oct 1, 2025
7f441cf
size_to_write and buffer_count changes didn't affect trie_sroted memo…
rodrigo-o Oct 1, 2025
57d9631
handle a case where snapshots become empty after a stale pivot
rodrigo-o Oct 1, 2025
ce53e50
go back to previous peer-level parallelism
rodrigo-o Oct 2, 2025
3475ee5
Unconditionally heal big accounts
jrchatruc Oct 2, 2025
30c3dc9
Added some comments and cleanup to the high level chunking
rodrigo-o Oct 2, 2025
c87fbcf
Added some comment and a bit of extra cleanup
rodrigo-o Oct 2, 2025
1d54144
formatting
rodrigo-o Oct 2, 2025
42a297e
Added one more comment
rodrigo-o Oct 2, 2025
c0ceeff
Update utils.rs
fedacking Oct 2, 2025
5580ea1
Update trie_sorted.rs
fedacking Oct 3, 2025
4bc928e
Fixed failing test
fedacking Oct 3, 2025
f9fcccd
Only call request_storage_ranges twice as a temporary solution while …
jrchatruc Oct 3, 2025
6656c32
Update server_runner.py
fedacking Oct 2, 2025
b50703d
Fix bug where we would get stuck trying to insert storage tries for a…
jrchatruc Oct 5, 2025
57a7d52
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 6, 2025
612a8d0
Readd rocksdb feature for p2p
jrchatruc Oct 6, 2025
1d0b580
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 6, 2025
cd4d1a3
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 6, 2025
dce6c08
Change log showing accounts sent for storage healing after request st…
jrchatruc Oct 6, 2025
259eb83
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 6, 2025
d51a7de
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 6, 2025
5110a89
fixed empty accounts case
fedacking Oct 6, 2025
35fd6be
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 6, 2025
508022e
Removed unneeded remove
fedacking Oct 6, 2025
d92e42b
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 6, 2025
34aebb2
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 6, 2025
dbc92d1
Merge branch 'main' into merge_optimizations_fast_insert_semaphore
jrchatruc Oct 7, 2025
bfdb207
Merge remote-tracking branch 'origin/merge_optimizations_fast_insert_…
rodrigo-o Oct 7, 2025
c2bacdd
remove guardrails for empty snapshots
rodrigo-o Oct 7, 2025
ffb17eb
Merge branch 'main' into chunk_storage_requests
rodrigo-o Oct 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed failing test
  • Loading branch information
fedacking committed Oct 3, 2025
commit 4bc928e9beadc50c1a4736efd1715c5adba01d7d
22 changes: 8 additions & 14 deletions crates/common/trie/trie_sorted.rs
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,6 @@ where
let mut center_side: CenterSide = CenterSide::from_value(initial_value.clone());
let mut right_side_opt: Option<(H256, Vec<u8>)> = data_iter.next();

// Edge Case
if right_side_opt.is_none() {
let node = LeafNode {
partial: center_side.path,
value: initial_value.1,
};
let hash = node.compute_hash();
flush_nodes_to_write(vec![(hash, node.into())], db, buffer_sender)?;
return Ok(hash.finalize());
}

while let Some(right_side) = right_side_opt {
if nodes_to_write.len() as u64 > SIZE_TO_WRITE_DB {
let buffer_sender = buffer_sender.clone();
Expand Down Expand Up @@ -250,7 +239,7 @@ where
.unwrap();

debug_assert!(nodes_to_write.last().unwrap().0 == child.compute_hash());
let (_, node_hash_ref) = nodes_to_write.iter_mut().last().unwrap();
let (node_hash, node_hash_ref) = nodes_to_write.iter_mut().last().unwrap();
match node_hash_ref {
Node::Branch(_) => {
let node: Node = ExtensionNode {
Expand All @@ -267,9 +256,14 @@ where
}
Node::Extension(extension_node) => {
extension_node.prefix.data.insert(0, index as u8);
extension_node.compute_hash().finalize()
*node_hash = extension_node.compute_hash();
node_hash.finalize()
}
Node::Leaf(leaf_node) => {
leaf_node.partial.data.insert(0, index as u8);
*node_hash = leaf_node.compute_hash();
node_hash.finalize()
}
Node::Leaf(leaf_node) => leaf_node.compute_hash().finalize(),
}
} else {
let node: Node = left_side.element.into();
Expand Down