Skip to content

chore(l1): chunk storage request during snapsync #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodrigo-o wants to merge 15 commits into
base: main
Choose a base branch
from
Open

chore(l1): chunk storage request during snapsync #4821

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
10200a1
initial chunk test
rodrigo-o Oct 1, 2025
d16e32b
reduce trie sorted size to write and buffer count
rodrigo-o Oct 1, 2025
d5c8d68
size_to_write and buffer_count changes didn't affect trie_sroted memo…
rodrigo-o Oct 1, 2025
a976d1d
handle a case where snapshots become empty after a stale pivot
rodrigo-o Oct 1, 2025
ceb3b09
go back to previous peer-level parallelism
rodrigo-o Oct 2, 2025
9d89961
Added some comments and cleanup to the high level chunking
rodrigo-o Oct 2, 2025
662c5fe
Added some comment and a bit of extra cleanup
rodrigo-o Oct 2, 2025
0f0027a
formatting
rodrigo-o Oct 2, 2025
a9de2e0
Added one more comment
rodrigo-o Oct 2, 2025
3f7d1ea
remove guardrails for empty snapshots
rodrigo-o Oct 7, 2025
524b1b9
Fix lint and formatting issues
rodrigo-o Oct 8, 2025
6170314
fix unintended diff
rodrigo-o Oct 8, 2025
a8ae5fb
readded else to avoid clippy error
rodrigo-o Oct 8, 2025
387fa17
fixed typo on an error message
rodrigo-o Oct 8, 2025
939a931
Merge branch 'main' into storage_request_chunking
rodrigo-o Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove guardrails for empty snapshots
  • Loading branch information
@rodrigo-o
rodrigo-o committed Oct 8, 2025
commit 3f7d1eae56e35adac6f9c2724fb1a7b1c16e34d4
25 changes: 8 additions & 17 deletions crates/networking/p2p/peer_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,11 +1399,6 @@ impl PeerHandler {
let current_account_storages = std::mem::take(&mut current_account_storages);
let snapshot = current_account_storages.into_values().collect::<Vec<_>>();

if snapshot.is_empty() {
// TODO: This happened while testing on pivot changes, we need to understand why
continue;
}

if !std::fs::exists(account_storages_snapshots_dir)
.map_err(|_| PeerHandlerError::NoStorageSnapshotsDir)?
{
Expand Down Expand Up @@ -1777,18 +1772,14 @@ impl PeerHandler {
std::fs::create_dir_all(account_storages_snapshots_dir)
.map_err(|_| PeerHandlerError::CreateStorageSnapshotsDir)?;
}
if snapshot.is_empty() {
// TODO: This happened while testing on pivot changes, we need to understand why
warn!(chunk = *chunk_index, "Skipping empty storage snapshot");
} else {
let path = get_account_storages_snapshot_file(
account_storages_snapshots_dir,
*chunk_index,
);
dump_storages_to_file(&path, snapshot)
.map_err(|_| PeerHandlerError::WriteStorageSnapshotsDir(*chunk_index))?;
*chunk_index += 1;
}

let path = get_account_storages_snapshot_file(
account_storages_snapshots_dir,
*chunk_index,
);
dump_storages_to_file(&path, snapshot)
.map_err(|_| PeerHandlerError::WriteStorageSnapshotsDir(*chunk_index))?;
*chunk_index += 1;
}
disk_joinset
.join_all()
Expand Down