Fix soundness hole of forgotten reach capabilities#20524
Merged
Linyxus merged 1 commit intoscala:mainfrom Jun 4, 2024
Merged
Conversation
hamzaremmal
reviewed
Jun 5, 2024
Member
There was a problem hiding this comment.
The following test failed in nightly with Scala 2 libary CC TASTy.
Wrong number of errors encountered when compiling tests/neg/i20503.scala
expected: 1, actual: 2
Unfulfilled expectations:
Unexpected errors:
tests/neg/i20503.scala:3
-> following the errors:
at 3: Reach capability cap and universal capability cap cannot both
appear in the type [U](f: box (() ->{ops*} Unit) => U): Unit of this expression
at 6: Found: (ops: List[box () ->? Unit]^?) => Unit
Required: (ops: List[box () => Unit]) -> Unit
See: https://github.com/scala/scala3/actions/runs/9377502987/job/25819168381
Contributor
Author
Member
|
I will look into this error |
Contributor
Author
|
@noti0na1 Thank you! |
Member
|
The extra error is at the type of When compiled with I tried the commit before this PR, and I can trigger the same error using the same setting. So this error is not related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20503