Only set AppliedType#validSuper after AppliedType#cachedSuper#20553
Merged
EugeneFlesselle merged 1 commit intoscala:mainfrom Jun 11, 2024
Merged
Only set AppliedType#validSuper after AppliedType#cachedSuper#20553EugeneFlesselle merged 1 commit intoscala:mainfrom
AppliedType#validSuper after AppliedType#cachedSuper#20553EugeneFlesselle merged 1 commit intoscala:mainfrom
Conversation
since cycles are possible when computing `AppliedType#superType`, see tests/neg/i20546.scala for an example leading to an NPE. We could use `ctx.period == validSuper && cachedSuper == null` as condition to detect cycles, but they are already handled in `TypeApplications#appliedTo`, with a better error message. We can update `AppliedType#validSuper` only after the computation is done to fix scala#20546
dwijnand
approved these changes
Jun 11, 2024
Contributor
Author
|
I should probably have added this as a comment in the test, I'm not particularly convinced this has to by a cyclic error, but at least we don't have a NPE and it's no longer a regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since cycles are possible when computing
AppliedType#superType, see tests/neg/i20546.scala for an example leading to an NPE.We could use
ctx.period == validSuper && cachedSuper == nullas condition to detect cycles, but they are already handled inTypeApplications#appliedTo, with a better error message.We can update
AppliedType#validSuperonly after the computation is done to fix #20546