Merged
Conversation
bishabosha
reviewed
Jun 25, 2024
bishabosha
reviewed
Jun 25, 2024
bishabosha
requested changes
Jun 25, 2024
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Contributor
Author
|
I wouldn't do it that way, since the path is available as a string. But I'm not one to stand in the way of anything. |
Member
|
Yeah I guess others might prefer to fail at runtime if you require the path to exist. |
bishabosha
approved these changes
Jun 25, 2024
WojciechMazur
added a commit
that referenced
this pull request
Jul 10, 2024
Backports #20775 to the LTS branch. PR submitted by the release tooling. [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20591
[skip ci]