Skip to content

Commit 1dbc8d9

Browse files
refactor(urlcomponent): rename output display names and method references (#8448)
* Update url.py * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * template updates * [autofix.ci] apply automated fixes * increase shards for testing * update name * fix-frontend-tests-url-component --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
1 parent 60ccdb5 commit 1dbc8d9

File tree

7 files changed

+24
-19
lines changed

7 files changed

+24
-19
lines changed

src/backend/base/langflow/components/data/url.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@
1818
DEFAULT_MAX_DEPTH = 1
1919
DEFAULT_FORMAT = "Text"
2020
URL_REGEX = re.compile(
21-
r"^(https?:\/\/)?" r"(www\.)?" r"([a-zA-Z0-9.-]+)" r"(\.[a-zA-Z]{2,})?" r"(:\d+)?" r"(\/[^\s]*)?$",
21+
r"^(https?:\/\/)?"
22+
r"(www\.)?"
23+
r"([a-zA-Z0-9.-]+)"
24+
r"(\.[a-zA-Z]{2,})?"
25+
r"(:\d+)?"
26+
r"(\/[^\s]*)?$",
2227
re.IGNORECASE,
2328
)
2429

@@ -164,8 +169,8 @@ class URLComponent(Component):
164169
]
165170

166171
outputs = [
167-
Output(display_name="Result", name="page_results", method="fetch_content"),
168-
Output(display_name="Raw Result", name="raw_results", method="as_message"),
172+
Output(display_name="Extracted Pages", name="page_results", method="fetch_content"),
173+
Output(display_name="Raw Content", name="raw_results", method="fetch_content_as_message"),
169174
]
170175

171176
@staticmethod
@@ -292,7 +297,7 @@ def fetch_content(self) -> DataFrame:
292297
"""Convert the documents to a DataFrame."""
293298
return DataFrame(data=self.fetch_url_contents())
294299

295-
def as_message(self) -> Message:
300+
def fetch_content_as_message(self) -> Message:
296301
"""Convert the documents to a Message."""
297302
url_contents = self.fetch_url_contents()
298303
return Message(text="\n\n".join([x["text"] for x in url_contents]), data={"data": url_contents})

src/backend/base/langflow/initial_setup/starter_projects/Blog Writer.json

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

src/frontend/tests/core/features/freeze.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ test(
114114

115115
//connection 1
116116
await page
117-
.getByTestId("handle-urlcomponent-shownode-result-right")
117+
.getByTestId("handle-urlcomponent-shownode-extracted pages-right")
118118
.nth(0)
119119
.click();
120120
await page

src/frontend/tests/core/features/stop-building.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ test(
7979
await zoomOut(page, 2);
8080

8181
//connection 1
82-
await page.getByTestId("handle-urlcomponent-shownode-result-right").click();
82+
await page.getByTestId("handle-urlcomponent-shownode-extracted pages-right").click();
8383
await page
8484
.getByTestId("handle-splittext-shownode-data or dataframe-left")
8585
.click();

src/frontend/tests/extended/features/loop-component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ test(
128128

129129
// URL -> Loop Data
130130
await page
131-
.getByTestId("handle-urlcomponent-shownode-result-right")
131+
.getByTestId("handle-urlcomponent-shownode-extracted pages-right")
132132
.first()
133133
.click();
134134
await page

src/frontend/tests/extended/integrations/chatInputOutputUser-shard-1.spec.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ test(
103103
.getByTestId("inputlist_str_urls_0")
104104
.fill("https://www.example.com");
105105

106-
await page.getByTestId("handle-urlcomponent-shownode-result-right").click();
106+
await page.getByTestId("handle-urlcomponent-shownode-extracted pages-right").click();
107107

108108
await page.waitForTimeout(600);
109109

@@ -128,7 +128,7 @@ test(
128128
exact: true,
129129
});
130130
await page.getByText("Close").first().click();
131-
await page.getByTestId("handle-urlcomponent-shownode-result-right").click();
131+
await page.getByTestId("handle-urlcomponent-shownode-extracted pages-right").click();
132132
await page
133133
.getByTestId("handle-chatoutput-noshownode-inputs-target")
134134
.nth(1)
@@ -141,12 +141,12 @@ test(
141141
timeout: 30000 * 3,
142142
});
143143

144-
await page.getByTestId("handle-urlcomponent-shownode-result-right").click();
144+
await page.getByTestId("handle-urlcomponent-shownode-extracted pages-right").click();
145145
await page.waitForTimeout(600);
146-
await page.getByTestId("handle-urlcomponent-shownode-result-right").click();
146+
await page.getByTestId("handle-urlcomponent-shownode-extracted pages-right").click();
147147

148148
await page
149-
.getByTestId("output-inspection-result-urlcomponent")
149+
.getByTestId("output-inspection-extracted pages-urlcomponent")
150150
.nth(0)
151151
.click();
152152

@@ -161,7 +161,7 @@ test(
161161
await page.waitForTimeout(600);
162162

163163
await page
164-
.getByTestId("handle-urlcomponent-shownode-result-right")
164+
.getByTestId("handle-urlcomponent-shownode-extracted pages-right")
165165
.nth(0)
166166
.click();
167167

@@ -176,7 +176,7 @@ test(
176176
timeout: 30000 * 3,
177177
});
178178
await page.waitForTimeout(600);
179-
await page.getByTestId("output-inspection-result-urlcomponent").click();
179+
await page.getByTestId("output-inspection-extracted pages-urlcomponent").click();
180180
await page.getByText(`Inspect the output of the component below.`, {
181181
exact: true,
182182
});

src/frontend/tests/extended/regression/general-bugs-truncate-results.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ test(
3434
timeout: 30000,
3535
});
3636

37-
await page.getByTestId("output-inspection-result-urlcomponent").click();
37+
await page.getByTestId("output-inspection-extracted pages-urlcomponent").click();
3838

3939
await page.getByText(`Inspect the output of the component below.`, {
4040
exact: true,

0 commit comments

Comments
 (0)