Merge pull request spatie#533 from dominikb/Issue-495_tighten_ignored_filter_value_definition

Update what defines an ignored filter value

Author: freekmurze

src/Filters/FiltersPartial.php

@@ -21,12 +21,12 @@ public function __invoke(Builder $query, $value, string $property)
         $sql = "LOWER({$wrappedProperty}) LIKE ?";
 
         if (is_array($value)) {
-            if (count(array_filter($value)) === 0) {
+            if (count(array_filter($value, 'strlen')) === 0) {
                 return $query;
             }
 
             $query->where(function (Builder $query) use ($value, $sql) {
-                foreach (array_filter($value) as $partialValue) {
+                foreach (array_filter($value, 'strlen') as $partialValue) {
                     $partialValue = mb_strtolower($partialValue, 'UTF8');
 
                     $query->orWhereRaw($sql, ["%{$partialValue}%"]);

tests/FilterTest.php

@@ -154,6 +154,21 @@ public function it_ignores_an_empty_array_partial_filter()
         $this->assertCount(5, $results);
     }
 
+    /** @test */
+    public function falsy_values_are_not_ignored_when_applying_a_partial_filter()
+    {
+        DB::enableQueryLog();
+
+        $this
+            ->createQueryFromFilterRequest([
+                'id' => [0],
+            ])
+            ->allowedFilters(AllowedFilter::partial('id'))
+            ->get();
+
+        $this->assertQueryLogContains("select * from `test_models` where (LOWER(`id`) LIKE ?)");
+    }
+
     /** @test */
     public function it_can_filter_and_match_results_by_exact_property()
     {