Skip to content

Commit 7269425

Browse files
hrant1020Hrant Aghanian
andauthored
[11.x] Add tests for handling non-baked enum and empty string requests (#51289)
* Add tests for handling non-baked enum and empty string requests * use existing request key --------- Co-authored-by: Hrant Aghanian <haghanian@ronasit.com>
1 parent 2f9a217 commit 7269425

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

tests/Http/Enums.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,13 @@
22

33
namespace Illuminate\Tests\Http;
44

5-
enum TestEnum: string
5+
enum TestEnumBacked: string
66
{
77
case test = 'test';
8+
case test_empty = '';
9+
}
10+
11+
enum TestEnum
12+
{
13+
case test;
814
}

tests/Http/HttpRequestTest.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -762,13 +762,16 @@ public function testEnumMethod()
762762
$request = Request::create('/', 'GET', [
763763
'valid_enum_value' => 'test',
764764
'invalid_enum_value' => 'invalid',
765+
'empty_value_request' => '',
765766
]);
766767

767-
$this->assertNull($request->enum('doesnt_exists', TestEnum::class));
768+
$this->assertNull($request->enum('doesnt_exists', TestEnumBacked::class));
768769

769-
$this->assertEquals(TestEnum::test, $request->enum('valid_enum_value', TestEnum::class));
770+
$this->assertEquals(TestEnumBacked::test, $request->enum('valid_enum_value', TestEnumBacked::class));
770771

771-
$this->assertNull($request->enum('invalid_enum_value', TestEnum::class));
772+
$this->assertNull($request->enum('invalid_enum_value', TestEnumBacked::class));
773+
$this->assertNull($request->enum('empty_value_request', TestEnumBacked::class));
774+
$this->assertNull($request->enum('valid_enum_value', TestEnum::class));
772775
}
773776

774777
public function testArrayAccess()

0 commit comments

Comments
 (0)