remove doctrine dbal from grammar

composer.json

@@ -163,7 +163,7 @@
         "ably/ably-php": "Required to use the Ably broadcast driver (^1.0).",
         "aws/aws-sdk-php": "Required to use the SQS queue driver, DynamoDb failed job storage, and SES mail driver (^3.235.5).",
         "brianium/paratest": "Required to run tests in parallel (^6.0).",
-        "doctrine/dbal": "Required to rename columns and drop SQLite columns (^4.0).",
+        "doctrine/dbal": "Required to modify SQLite columns (^4.0).",
         "fakerphp/faker": "Required to use the eloquent factory builder (^1.9.1).",
         "filp/whoops": "Required for friendly error pages in development (^2.14.3).",
         "guzzlehttp/guzzle": "Required to use the HTTP Client and the ping methods on schedules (^7.6).",

src/Illuminate/Database/Connection.php

@@ -1226,20 +1226,6 @@ public function usingNativeSchemaOperations()
         return ! $this->isDoctrineAvailable() || SchemaBuilder::$alwaysUsesNativeSchemaOperationsIfPossible;
     }
 
-    /**
-     * Get a Doctrine Schema Column instance.
-     *
-     * @param  string  $table
-     * @param  string  $column
-     * @return \Doctrine\DBAL\Schema\Column
-     */
-    public function getDoctrineColumn($table, $column)
-    {
-        $schema = $this->getDoctrineSchemaManager();
-
-        return $schema->introspectTable($table)->getColumn($column);
-    }
-
     /**
      * Get the Doctrine DBAL schema manager for the connection.
      *

src/Illuminate/Database/Schema/Blueprint.php

@@ -153,13 +153,6 @@ public function toSql(Connection $connection, Grammar $grammar)
     protected function ensureCommandsAreValid(Connection $connection)
     {
         if ($connection instanceof SQLiteConnection) {
-            if ($this->commandsNamed(['dropColumn', 'renameColumn'])->count() > 1
-                && ! $connection->usingNativeSchemaOperations()) {
-                throw new BadMethodCallException(
-                    "SQLite doesn't support multiple calls to dropColumn / renameColumn in a single modification."
-                );
-            }
-
             if ($this->commandsNamed(['dropForeign'])->count() > 0) {
                 throw new BadMethodCallException(
                     "SQLite doesn't support dropping foreign keys (you would need to re-create the table)."

src/Illuminate/Database/Schema/Builder.php

@@ -238,14 +238,6 @@ public function whenTableDoesntHaveColumn(string $table, string $column, Closure
      */
     public function getColumnType($table, $column, $fullDefinition = false)
     {
-        $table = $this->connection->getTablePrefix().$table;
-
-        if (! $this->connection->usingNativeSchemaOperations()) {
-            $type = $this->connection->getDoctrineColumn($table, $column)->getType();
-
-            return $type::lookupName($type);
-        }
-
         $columns = $this->getColumns($table);
 
         foreach ($columns as $value) {

src/Illuminate/Database/Schema/Grammars/Grammar.php

@@ -3,8 +3,6 @@
 namespace Illuminate\Database\Schema\Grammars;
 
 use BackedEnum;
-use Doctrine\DBAL\Schema\AbstractSchemaManager as SchemaManager;
-use Doctrine\DBAL\Schema\TableDiff;
 use Illuminate\Contracts\Database\Query\Expression;
 use Illuminate\Database\Concerns\CompilesJsonPaths;
 use Illuminate\Database\Connection;
@@ -76,7 +74,11 @@ public function compileDropDatabaseIfExists($name)
      */
     public function compileRenameColumn(Blueprint $blueprint, Fluent $command, Connection $connection)
     {
-        return RenameColumn::compile($this, $blueprint, $command, $connection);
+        return sprintf('alter table %s rename column %s to %s',
+            $this->wrapTable($blueprint),
+            $this->wrap($command->from),
+            $this->wrap($command->to)
+        );
     }
 
     /**
@@ -319,22 +321,6 @@ protected function getDefaultValue($value)
                     : "'".(string) $value."'";
     }
 
-    /**
-     * Create an empty Doctrine DBAL TableDiff from the Blueprint.
-     *
-     * @param  \Illuminate\Database\Schema\Blueprint  $blueprint
-     * @param  \Doctrine\DBAL\Schema\AbstractSchemaManager  $schema
-     * @return \Doctrine\DBAL\Schema\TableDiff
-     */
-    public function getDoctrineTableDiff(Blueprint $blueprint, SchemaManager $schema)
-    {
-        $tableName = $this->getTablePrefix().$blueprint->getTable();
-
-        $table = $schema->introspectTable($tableName);
-
-        return $schema->createComparator()->compareTables(oldTable: $table, newTable: $table);
-    }
-
     /**
      * Get the fluent commands for the grammar.
      *

src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php

@@ -230,25 +230,6 @@ public function compileAutoIncrementStartingValues(Blueprint $blueprint, Fluent
         }
     }
 
-    /**
-     * Compile a rename column command.
-     *
-     * @param  \Illuminate\Database\Schema\Blueprint  $blueprint
-     * @param  \Illuminate\Support\Fluent  $command
-     * @param  \Illuminate\Database\Connection  $connection
-     * @return array|string
-     */
-    public function compileRenameColumn(Blueprint $blueprint, Fluent $command, Connection $connection)
-    {
-        return $connection->usingNativeSchemaOperations()
-            ? sprintf('alter table %s rename column %s to %s',
-                $this->wrapTable($blueprint),
-                $this->wrap($command->from),
-                $this->wrap($command->to)
-            )
-            : parent::compileRenameColumn($blueprint, $command, $connection);
-    }
-
     /**
      * Compile a change column command into a series of SQL statements.
      *

src/Illuminate/Database/Schema/Grammars/PostgresGrammar.php

@@ -160,25 +160,6 @@ public function compileAutoIncrementStartingValues(Blueprint $blueprint, Fluent
         }
     }
 
-    /**
-     * Compile a rename column command.
-     *
-     * @param  \Illuminate\Database\Schema\Blueprint  $blueprint
-     * @param  \Illuminate\Support\Fluent  $command
-     * @param  \Illuminate\Database\Connection  $connection
-     * @return array|string
-     */
-    public function compileRenameColumn(Blueprint $blueprint, Fluent $command, Connection $connection)
-    {
-        return $connection->usingNativeSchemaOperations()
-            ? sprintf('alter table %s rename column %s to %s',
-                $this->wrapTable($blueprint),
-                $this->wrap($command->from),
-                $this->wrap($command->to)
-            )
-            : parent::compileRenameColumn($blueprint, $command, $connection);
-    }
-
     /**
      * Compile a change column command into a series of SQL statements.
      *

src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php

@@ -3,7 +3,6 @@
 namespace Illuminate\Database\Schema\Grammars;
 
 use Doctrine\DBAL\Schema\Index;
-use Doctrine\DBAL\Schema\TableDiff;
 use Illuminate\Database\Connection;
 use Illuminate\Database\Query\Expression;
 use Illuminate\Database\Schema\Blueprint;
@@ -163,25 +162,6 @@ public function compileAdd(Blueprint $blueprint, Fluent $command)
         })->all();
     }
 
-    /**
-     * Compile a rename column command.
-     *
-     * @param  \Illuminate\Database\Schema\Blueprint  $blueprint
-     * @param  \Illuminate\Support\Fluent  $command
-     * @param  \Illuminate\Database\Connection  $connection
-     * @return array|string
-     */
-    public function compileRenameColumn(Blueprint $blueprint, Fluent $command, Connection $connection)
-    {
-        return $connection->usingNativeSchemaOperations()
-            ? sprintf('alter table %s rename column %s to %s',
-                $this->wrapTable($blueprint),
-                $this->wrap($command->from),
-                $this->wrap($command->to)
-            )
-            : parent::compileRenameColumn($blueprint, $command, $connection);
-    }
-
     /**
      * Compile a unique key command.
      *
@@ -324,45 +304,11 @@ public function compileRebuild()
      */
     public function compileDropColumn(Blueprint $blueprint, Fluent $command, Connection $connection)
     {
-        if ($connection->usingNativeSchemaOperations()) {
-            $table = $this->wrapTable($blueprint);
-
-            $columns = $this->prefixArray('drop column', $this->wrapArray($command->columns));
-
-            return collect($columns)->map(fn ($column) => 'alter table '.$table.' '.$column
-            )->all();
-        } else {
-            $tableDiff = $this->getDoctrineTableDiff(
-                $blueprint, $schema = $connection->getDoctrineSchemaManager()
-            );
+        $table = $this->wrapTable($blueprint);
 
-            $droppedColumns = [];
+        $columns = $this->prefixArray('drop column', $this->wrapArray($command->columns));
 
-            foreach ($command->columns as $name) {
-                $droppedColumns[$name] = $connection->getDoctrineColumn(
-                    $this->getTablePrefix().$blueprint->getTable(), $name
-                );
-            }
-
-            $platform = $connection->getDoctrineConnection()->getDatabasePlatform();
-
-            return (array) $platform->getAlterTableSQL(
-                new TableDiff(
-                    $tableDiff->getOldTable(),
-                    $tableDiff->getAddedColumns(),
-                    $tableDiff->getModifiedColumns(),
-                    $droppedColumns,
-                    $tableDiff->getRenamedColumns(),
-                    $tableDiff->getAddedIndexes(),
-                    $tableDiff->getModifiedIndexes(),
-                    $tableDiff->getDroppedIndexes(),
-                    $tableDiff->getRenamedIndexes(),
-                    $tableDiff->getAddedForeignKeys(),
-                    $tableDiff->getModifiedColumns(),
-                    $tableDiff->getDroppedForeignKeys(),
-                )
-            );
-        }
+        return collect($columns)->map(fn ($column) => 'alter table '.$table.' '.$column)->all();
     }
 
     /**

src/Illuminate/Database/Schema/Grammars/SqlServerGrammar.php

@@ -153,12 +153,10 @@ public function compileAdd(Blueprint $blueprint, Fluent $command)
      */
     public function compileRenameColumn(Blueprint $blueprint, Fluent $command, Connection $connection)
     {
-        return $connection->usingNativeSchemaOperations()
-            ? sprintf("sp_rename '%s', %s, 'COLUMN'",
-                $this->wrap($blueprint->getTable().'.'.$command->from),
-                $this->wrap($command->to)
-            )
-            : parent::compileRenameColumn($blueprint, $command, $connection);
+        return sprintf("sp_rename '%s', %s, 'COLUMN'",
+            $this->wrap($blueprint->getTable().'.'.$command->from),
+            $this->wrap($command->to)
+        );
     }
 
     /**

tests/Database/DatabaseSchemaBuilderTest.php

@@ -5,6 +5,7 @@
 use Doctrine\DBAL\Schema\Column;
 use Doctrine\DBAL\Types\Type;
 use Illuminate\Database\Connection;
+use Illuminate\Database\Query\Processors\Processor;
 use Illuminate\Database\Schema\Builder;
 use Illuminate\Database\Schema\Grammars\Grammar;
 use LogicException;
@@ -73,16 +74,15 @@ public function testTableHasColumns()
     public function testGetColumnTypeAddsPrefix()
     {
         $connection = m::mock(Connection::class);
-        $column = m::mock(Column::class);
-        $type = m::mock(Type::class);
         $grammar = m::mock(Grammar::class);
+        $processor = m::mock(Processor::class);
         $connection->shouldReceive('getSchemaGrammar')->once()->andReturn($grammar);
+        $connection->shouldReceive('getPostProcessor')->andReturn($processor);
+        $processor->shouldReceive('processColumns')->once()->andReturn([['name' => 'id', 'type_name' => 'integer']]);
         $builder = new Builder($connection);
         $connection->shouldReceive('getTablePrefix')->once()->andReturn('prefix_');
-        $connection->shouldReceive('getDoctrineColumn')->once()->with('prefix_users', 'id')->andReturn($column);
-        $connection->shouldReceive('usingNativeSchemaOperations')->once()->andReturn(false);
-        $column->shouldReceive('getType')->once()->andReturn($type);
-        $type->shouldReceive('lookupName')->once()->andReturn('integer');
+        $grammar->shouldReceive('compileColumns')->once()->with('prefix_users')->andReturn('sql');
+        $connection->shouldReceive('selectFromWriteConnection')->once()->with('sql')->andReturn([['name' => 'id', 'type_name' => 'integer']]);
 
         $this->assertSame('integer', $builder->getColumnType('users', 'id'));
     }