Skip to content

Commit f109d7e

Browse files
committed
Merge pull request ptomasroos#40 from fomahaut/master
Fix examples and README for ptomasroos#22, ptomasroos#38
2 parents dc97648 + 27e3fb9 commit f109d7e

File tree

7 files changed

+21
-20
lines changed

7 files changed

+21
-20
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
npm-debug.log
2+
node_modules/
3+
.idea/

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,8 @@ var CustomTabBar = React.createClass({
103103
var isTabActive = this.props.activeTab === page;
104104

105105
return (
106-
<TouchableOpacity key={name} onPress={() => this.props.goToPage(page)}>
107-
<View style={[styles.tab]}>
108-
<Text style={{color: isTabActive ? 'navy' : 'black', fontWeight: isTabActive ? 'bold' : 'normal'}}>{name}</Text>
109-
</View>
106+
<TouchableOpacity key={name} onPress={() => this.props.goToPage(page)} style={[styles.tab]}>
107+
<Text style={{color: isTabActive ? 'navy' : 'black', fontWeight: isTabActive ? 'bold' : 'normal'}}>{name}</Text>
110108
</TouchableOpacity>
111109
);
112110
},

examples/FacebookTabsExample/FacebookTabBar.js

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,11 @@ var FacebookTabBar = React.createClass({
4747
console.log(name);
4848

4949
return (
50-
<TouchableOpacity key={name} onPress={() => this.props.goToPage(page)}>
51-
<View style={[styles.tab]}>
52-
<Icon name={name} size={30} color='#3B5998' style={{width: 30, height: 30, position: 'absolute', top: 0, left: 20}}
53-
ref={(icon) => { this.selectedTabIcons[page] = icon }}/>
54-
<Icon name={name} size={30} color='#ccc' style={{width: 30, height: 30, position: 'absolute', top: 0, left: 20}}
55-
ref={(icon) => { this.unselectedTabIcons[page] = icon }}/>
56-
</View>
50+
<TouchableOpacity key={name} onPress={() => this.props.goToPage(page)} style={[styles.tab]}>
51+
<Icon name={name} size={30} color='#3B5998' style={{width: 30, height: 30, position: 'absolute', top: 0, left: 20}}
52+
ref={(icon) => { this.selectedTabIcons[page] = icon }}/>
53+
<Icon name={name} size={30} color='#ccc' style={{width: 30, height: 30, position: 'absolute', top: 0, left: 20}}
54+
ref={(icon) => { this.unselectedTabIcons[page] = icon }}/>
5755
</TouchableOpacity>
5856
);
5957
},
@@ -62,11 +60,16 @@ var FacebookTabBar = React.createClass({
6260
var currentPage = this.props.activeTab;
6361

6462
this.unselectedTabIcons.forEach((icon, i) => {
63+
var iconRef = icon;
64+
65+
if(!icon.setNativeProps && icon !== null) {
66+
iconRef = icon.refs.icon_image
67+
}
6568
if (value - i >= 0 && value - i <= 1) {
66-
icon.setNativeProps({opacity: value - i});
69+
iconRef.setNativeProps({opacity: value - i});
6770
}
6871
if (i - value >= 0 && i - value <= 1) {
69-
icon.setNativeProps({opacity: i - value});
72+
iconRef.setNativeProps({opacity: i - value});
7073
}
7174
});
7275
},

examples/FacebookTabsExample/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"start": "node_modules/react-native/packager/packager.sh"
77
},
88
"dependencies": {
9-
"react-native": "0.8.0",
9+
"react-native": "0.9.0",
1010
"react-native-icons": "^0.2.0",
1111
"react-native-scrollable-tab-view": "^0.1.10"
1212
}

examples/RugbyExample/ScrollingTabBar.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,8 @@ var ScrollingTabBar = React.createClass({
4747
extrapolate: 'clamp'});
4848

4949
return (
50-
<TouchableOpacity key={name} onPress={() => this.props.goToPage(page)}>
51-
<Animated.View style={[styles.tab]}>
52-
<Animated.Text style={{color}}>{name}</Animated.Text>
53-
</Animated.View>
50+
<TouchableOpacity key={name} onPress={() => this.props.goToPage(page)} style={[styles.tab]}>
51+
<Animated.Text style={{color}}>{name}</Animated.Text>
5452
</TouchableOpacity>
5553
);
5654
},

examples/RugbyExample/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
"start": "node_modules/react-native/packager/packager.sh"
77
},
88
"dependencies": {
9-
"react-native": "^0.8.0"
9+
"react-native": "^0.9.0"
1010
}
1111
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
},
2626
"homepage": "https://github.com/brentvatne/react-native-scrollable-tab-view#readme",
2727
"peerDependencies": {
28-
"react-native": ">=0.8.0 || 0.8.0-rc || 0.8.0-rc.2 || 0.9.0-rc || 0.10.0-rc"
28+
"react-native": ">=0.9.0 || 0.9.0-rc || 0.10.0-rc || 0.11.0-rc"
2929
},
3030
"dependencies": {
3131
"rebound": "0.0.13"

0 commit comments

Comments
 (0)