From f519fee977e678b651e9678b2ab40013a8c72b43 Mon Sep 17 00:00:00 2001 From: "Roman S. Borschel" Date: Mon, 7 Sep 2020 12:06:39 +0200 Subject: [PATCH 1/2] libp2p-kad: Increase default max packet size. For better interoperability by default, picking up the suggestion in https://github.com/libp2p/rust-libp2p/issues/1622. --- protocols/kad/src/protocol.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/protocols/kad/src/protocol.rs b/protocols/kad/src/protocol.rs index 13b1320a172..58ca1c3d840 100644 --- a/protocols/kad/src/protocol.rs +++ b/protocols/kad/src/protocol.rs @@ -43,6 +43,9 @@ use wasm_timer::Instant; /// The protocol name used for negotiating with multistream-select. pub const DEFAULT_PROTO_NAME: &[u8] = b"/ipfs/kad/1.0.0"; +/// The default maximum size for a varint length-delimited packet. +pub const DEFAULT_MAX_PACKET_SIZE: usize = 16 * 1024; + /// Status of our connection to a node reported by the Kademlia protocol. #[derive(Copy, Clone, PartialEq, Eq, Debug, Hash)] pub enum KadConnectionType { @@ -167,7 +170,7 @@ impl Default for KademliaProtocolConfig { fn default() -> Self { KademliaProtocolConfig { protocol_name: Cow::Borrowed(DEFAULT_PROTO_NAME), - max_packet_size: 4096, + max_packet_size: DEFAULT_MAX_PACKET_SIZE, } } } From a35789a2cdfa5fdbd3dc530af0043733dc8dca96 Mon Sep 17 00:00:00 2001 From: "Roman S. Borschel" Date: Mon, 7 Sep 2020 12:11:01 +0200 Subject: [PATCH 2/2] Update changelog. --- protocols/kad/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/protocols/kad/CHANGELOG.md b/protocols/kad/CHANGELOG.md index 99c06c6b1a9..0c2db6e13b2 100644 --- a/protocols/kad/CHANGELOG.md +++ b/protocols/kad/CHANGELOG.md @@ -1,5 +1,8 @@ # 0.23.0 [unreleased] +- Increase default max packet size from 4KiB to 16KiB. + See [issue 1622](https://github.com/libp2p/rust-libp2p/issues/1622). + - Add `Distance::log2` ([PR 1719](https://github.com/libp2p/rust-libp2p/pull/1719)). - Update `libp2p-swarm` and `libp2p-core`.