lower-case enum values like lila did

keeps compatibility with existing data in DB, and potentially URLs

Author: ornicar

core/src/main/scala/model.scala

@@ -42,7 +42,7 @@ opaque type FideId = Int
 object FideId extends OpaqueInt[FideId]
 
 enum FideTC:
-  case Standard, Rapid, Blitz
+  case standard, rapid, blitz
 
 opaque type PlayerName = String
 object PlayerName extends OpaqueString[PlayerName]

rating/src/main/scala/Elo.scala

@@ -28,7 +28,7 @@ object Elo extends RichOpaqueInt[Elo]:
   def computeNewRating(tc: FideTC)(player: Player, games: Seq[Game]): Elo =
     val playerElo = player.rating
     def rnbUnratedCondition(opponentElo: Elo): Boolean =
-      tc != FideTC.Standard &&
+      tc != FideTC.standard &&
         (opponentElo - playerElo).abs >= 600 && List(playerElo, opponentElo).exists(_ > 2600)
     val expectedScore = games.foldMap: game =>
       if rnbUnratedCondition(game.opponentRating)
@@ -46,7 +46,7 @@ object Elo extends RichOpaqueInt[Elo]:
    */
   def adjustedRatingDiff(tc: FideTC)(playerElo: Elo, opponentElo: Elo): Int =
     val ratingDiff = opponentElo - playerElo
-    if tc == FideTC.Standard && playerElo >= 2650 then ratingDiff
+    if tc == FideTC.standard && playerElo >= 2650 then ratingDiff
     else ratingDiff.atLeast(-400).atMost(400)
 
   def getExpectedScore(ratingDiff: Int): Float =

test-kit/src/test/scala/rating/EloTest.scala

@@ -21,7 +21,7 @@ class EloTest extends ChessTest:
 
   private def ratingDiffStandard(r: Int, k: Int, opRating: Int, points: Outcome.Points, expected: Int)(using
       munit.Location
-  ) = ratingDiff(r, k, opRating, points, FideTC.Standard, expected)
+  ) = ratingDiff(r, k, opRating, points, FideTC.standard, expected)
 
   test("new rating calculation over one game"):
     ratingDiffStandard(1500, 40, 1500, One, 20)
@@ -49,19 +49,19 @@ class EloTest extends ChessTest:
 
   test("new rating calculation over multiple games"):
     assertEquals(
-      Elo.computeRatingDiff(FideTC.Standard)(
+      Elo.computeRatingDiff(FideTC.standard)(
         Elo.Player(Elo(2800), KFactor(10)),
         List.fill(11)(Elo.Game(One, Elo(1800)))
       ),
       0
     )
 
   test("new rating calculation rapid/blitz"):
-    ratingDiff(1800, 40, 2601, Zero, FideTC.Rapid, 0)
-    ratingDiff(2601, 10, 1800, One, FideTC.Rapid, 0)
-    ratingDiff(2600, 10, 1900, One, FideTC.Rapid, 1)
-    ratingDiff(1500, 40, 1500, One, FideTC.Rapid, 20)
-    ratingDiff(1500, 40, 1900, Half, FideTC.Blitz, 17)
+    ratingDiff(1800, 40, 2601, Zero, FideTC.rapid, 0)
+    ratingDiff(2601, 10, 1800, One, FideTC.rapid, 0)
+    ratingDiff(2600, 10, 1900, One, FideTC.rapid, 1)
+    ratingDiff(1500, 40, 1500, One, FideTC.rapid, 20)
+    ratingDiff(1500, 40, 1900, Half, FideTC.blitz, 17)
 
   private def expectedScore(ratingDiff: Int, expScore: Float)(using munit.Location) =
     assertCloseTo(Elo.getExpectedScore(ratingDiff), expScore, 0.001f)