Skip to content

Commit 0fe8043

Browse files
committed
ref(syncpromise): correct imports
1 parent cd6dada commit 0fe8043

File tree

7 files changed

+20
-23
lines changed

7 files changed

+20
-23
lines changed

packages/browser/src/eventbuilder.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
isErrorEvent,
99
isEvent,
1010
isPlainObject,
11-
resolvedSyncPromise,
11+
makeSyncPromise,
1212
} from '@sentry/utils';
1313

1414
import { eventFromPlainObject, eventFromStacktrace, prepareFramesForEvent } from './parsers';
@@ -28,7 +28,7 @@ export function eventFromException(options: Options, exception: unknown, hint?:
2828
if (hint && hint.event_id) {
2929
event.event_id = hint.event_id;
3030
}
31-
return resolvedSyncPromise(event);
31+
return makeSyncPromise().resolve(event);
3232
}
3333

3434
/**
@@ -49,7 +49,7 @@ export function eventFromMessage(
4949
if (hint && hint.event_id) {
5050
event.event_id = hint.event_id;
5151
}
52-
return resolvedSyncPromise(event);
52+
return makeSyncPromise().resolve(event);
5353
}
5454

5555
/**

packages/browser/src/sdk.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ export const defaultIntegrations = [
6363
* ```
6464
*
6565
* import * as Sentry from '@sentry/browser';
66+
import { makeSyncPromise } from '../../utils/src/syncpromise';
6667
* Sentry.captureMessage('Hello, world!');
6768
* Sentry.captureException(new Error('Good bye'));
6869
* Sentry.captureEvent({
@@ -162,10 +163,8 @@ export function flush(timeout?: number): PromiseLike<boolean> {
162163
if (client) {
163164
return client.flush(timeout);
164165
}
165-
if (isDebugBuild()) {
166-
logger.warn('Cannot flush events. No client defined.');
167-
}
168-
return resolvedSyncPromise(false);
166+
logger.warn('Cannot flush events. No client defined.');
167+
return makeSyncPromise().resolve(false);
169168
}
170169

171170
/**
@@ -181,10 +180,8 @@ export function close(timeout?: number): PromiseLike<boolean> {
181180
if (client) {
182181
return client.close(timeout);
183182
}
184-
if (isDebugBuild()) {
185-
logger.warn('Cannot flush events and disable SDK. No client defined.');
186-
}
187-
return resolvedSyncPromise(false);
183+
logger.warn('Cannot flush events and disable SDK. No client defined.');
184+
return makeSyncPromise().resolve(false);
188185
}
189186

190187
/**

packages/browser/test/unit/mocks/simpletransport.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
import { eventStatusFromHttpCode, resolvedSyncPromise } from '@sentry/utils';
1+
import { eventStatusFromHttpCode, makeSyncPromise } from '@sentry/utils';
22

33
import { Event, Response } from '../../../src';
44
import { BaseTransport } from '../../../src/transports';
55

66
export class SimpleTransport extends BaseTransport {
77
public sendEvent(_: Event): PromiseLike<Response> {
88
return this._buffer.add(() =>
9-
resolvedSyncPromise({
9+
makeSyncPromise().resolve({
1010
status: eventStatusFromHttpCode(200),
1111
}),
1212
);

packages/core/src/baseclient.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
363363
}
364364

365365
// We prepare the result here with a resolved Event.
366-
let result = resolvedSyncPromise<Event | null>(prepared);
366+
let result = makeSyncPromise().resolve<Event | null>(prepared);
367367

368368
// This should be the last thing called, since we want that
369369
// {@link Hub.addEventProcessor} gets the finished prepared event.
@@ -538,7 +538,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
538538
}
539539

540540
if (!this._isEnabled()) {
541-
return rejectedSyncPromise(new SentryError('SDK not enabled, will not capture event.'));
541+
return makeSyncPromise().reject(new SentryError('SDK not enabled, will not capture event.'));
542542
}
543543

544544
const isTransaction = event.type === 'transaction';
@@ -547,7 +547,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
547547
// Sampling for transaction happens somewhere else
548548
if (!isTransaction && typeof sampleRate === 'number' && Math.random() > sampleRate) {
549549
recordLostEvent('sample_rate', 'event');
550-
return rejectedSyncPromise(
550+
return makeSyncPromise().reject(
551551
new SentryError(
552552
`Discarding event because it's not included in the random sample (sampling rate = ${sampleRate})`,
553553
),
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import { Event, Response, Transport } from '@sentry/types';
2-
import { resolvedSyncPromise } from '@sentry/utils';
2+
import { makeSyncPromise } from '@sentry/utils';
33

44
/** Noop transport */
55
export class NoopTransport implements Transport {
66
/**
77
* @inheritDoc
88
*/
99
public sendEvent(_: Event): PromiseLike<Response> {
10-
return resolvedSyncPromise({
10+
return makeSyncPromise().resolve({
1111
reason: `NoopTransport: Event has been skipped because no Dsn is configured.`,
1212
status: 'skipped',
1313
});
@@ -17,6 +17,6 @@ export class NoopTransport implements Transport {
1717
* @inheritDoc
1818
*/
1919
public close(_?: number): PromiseLike<boolean> {
20-
return resolvedSyncPromise(true);
20+
return makeSyncPromise().resolve(true);
2121
}
2222
}

packages/core/test/mocks/backend.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Session } from '@sentry/hub';
22
import { Event, Options, SeverityLevel, Transport } from '@sentry/types';
3-
import { resolvedSyncPromise } from '@sentry/utils';
3+
import { makeSyncPromise } from '@sentry/utils';
44

55
import { BaseBackend } from '../../src/basebackend';
66

@@ -24,7 +24,7 @@ export class TestBackend extends BaseBackend<TestOptions> {
2424

2525
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
2626
public eventFromException(exception: any): PromiseLike<Event> {
27-
return resolvedSyncPromise({
27+
return makeSyncPromise().resolve({
2828
exception: {
2929
values: [
3030
{
@@ -39,7 +39,7 @@ export class TestBackend extends BaseBackend<TestOptions> {
3939
}
4040

4141
public eventFromMessage(message: string, level: SeverityLevel = 'info'): PromiseLike<Event> {
42-
return resolvedSyncPromise({ message, level });
42+
return makeSyncPromise().resolve({ message, level });
4343
}
4444

4545
public sendEvent(event: Event): void {

packages/utils/src/syncpromise.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export interface SyncPromise<T> extends PromiseLike<T> {
2727
catch: <TResult = never>(
2828
onrejected?: ((reason: any) => TResult | PromiseLike<TResult>) | null,
2929
) => PromiseLike<T | TResult>;
30-
resolve: (value: T | PromiseLike<T>) => PromiseLike<T>;
30+
resolve: <T>(value: T | PromiseLike<T>) => PromiseLike<T>;
3131
reject: <T = never>(reason?: any) => PromiseLike<T>;
3232
}
3333
/**

0 commit comments

Comments
 (0)