-
Notifications
You must be signed in to change notification settings - Fork 17
Print generated VC from CLI command #2256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print generated VC from CLI command #2256
Conversation
P-177 Print the result to stdout for `request-vc` CLI
A follow-up issue of P-166 Currently the CLI only returns the top status, see As we support synchronous DI response, it should be possible to print the result directly to stdout, either the generated VC, or any emitted error. It's split into two issues (PRs) for better readability. |
|
I wasn't sure now how did my test before (without this commit in this PR) even work: #2248 (see the cli test results in the PR...) |
|
But this would be very helpful for testing, before this I used to need to get the VC from explorer |
You can find VC content in worker logs. |
Kailai-Wang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Integirtee might be interested in perform_trusted_operation change too
tee-worker/cli/src/trusted_base_cli/commands/litentry/link_identity.rs
Outdated
Show resolved
Hide resolved
BillyWooo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| let json_value = RpcReturnValue { | ||
| do_watch: false, | ||
| value: response.encode(), | ||
| value: response, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixfaisal fyi
resolves: P-177
perform_trusted_operationallows to specify the type of theTrustedOpResult::Okvariant, so no additional decoding is needed.aes_decryptfunction - result ofopen_in_placeshould be returned as it doesn't containt the tag