Skip to content

[CIR][ThroughMLIR] Templatize unary math op lowerings. #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025
Merged

[CIR][ThroughMLIR] Templatize unary math op lowerings. #1557

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb14931
Templatise math operations
goxul Apr 2, 2025
a664d58
1. Fix template name 2. run clang-format
goxul Apr 11, 2025
79ac64c
Add comment to describe changes
goxul Apr 11, 2025
7dedb7e
clang-format
goxul Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
clang-format
  • Loading branch information
@goxul
goxul committed Apr 11, 2025
commit 7dedb7e5f411aa1f457959fc7196dcaa7947d081
5 changes: 3 additions & 2 deletions clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,9 @@ class CIRStoreOpLowering : public mlir::OpConversionPattern<cir::StoreOp> {
}
};

/// Converts CIR unary math ops (e.g., cir::SinOp) to their MLIR equivalents (e.g., math::SinOp)
/// using a generic template to avoid redundant boilerplate matchAndRewrite definitions.
/// Converts CIR unary math ops (e.g., cir::SinOp) to their MLIR equivalents
/// (e.g., math::SinOp) using a generic template to avoid redundant boilerplate
/// matchAndRewrite definitions.

template <typename CIROp, typename MLIROp>
class CIRUnaryMathOpLowering : public mlir::OpConversionPattern<CIROp> {
Expand Down
Loading