From 5bca07187b4167bffd1248f8b23ffccc3ccc1b4c Mon Sep 17 00:00:00 2001 From: agazizov Date: Mon, 5 Apr 2021 01:40:03 +0300 Subject: [PATCH 1/2] Avoid calling 'toArray' with pre-sized array argument --- .../logback/appender/AbstractLogstashTcpSocketAppender.java | 2 +- .../net/logstash/logback/appender/AsyncDisruptorAppender.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java b/src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java index 3909b972..15e269ef 100644 --- a/src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java +++ b/src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java @@ -1106,7 +1106,7 @@ public void addDestination(final String destination) throws IllegalArgumentExcep List parsedDestinations = DestinationParser.parse(destination, DEFAULT_PORT); - addDestinations(parsedDestinations.toArray(new InetSocketAddress[parsedDestinations.size()])); + addDestinations(parsedDestinations.toArray(new InetSocketAddress[0])); } /** diff --git a/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java b/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java index 3ce19aed..29c3a9c4 100644 --- a/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java +++ b/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java @@ -474,7 +474,7 @@ protected void prepareForDeferredProcessing(Event event) { protected String calculateThreadName() { List threadNameFormatParams = getThreadNameFormatParams(); - return String.format(threadNameFormat, threadNameFormatParams.toArray(new Object[threadNameFormatParams.size()])); + return String.format(threadNameFormat, threadNameFormatParams.toArray(new Object[0])); } protected List getThreadNameFormatParams() { From 7bd5243defc563e7108cc8527e2dc437544d5291 Mon Sep 17 00:00:00 2001 From: agazizov Date: Mon, 5 Apr 2021 01:55:14 +0300 Subject: [PATCH 2/2] Avoid calling 'toArray' with pre-sized array argument --- .../net/logstash/logback/appender/AsyncDisruptorAppender.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java b/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java index 29c3a9c4..b433cc07 100644 --- a/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java +++ b/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java @@ -474,7 +474,7 @@ protected void prepareForDeferredProcessing(Event event) { protected String calculateThreadName() { List threadNameFormatParams = getThreadNameFormatParams(); - return String.format(threadNameFormat, threadNameFormatParams.toArray(new Object[0])); + return String.format(threadNameFormat, threadNameFormatParams.toArray()); } protected List getThreadNameFormatParams() {