This repository was archived by the owner on Mar 8, 2020. It is now read-only.
WIP password change: routes and view. Not working yet.#13
Draft
JessicaKCao wants to merge 2 commits into
Draft
Conversation
mdworken
reviewed
Mar 2, 2019
Author
|
@mdworken can you please review again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4
Description
The feature is now working and has a feature test. Let me know if there are concerns or questions.
Type of change
How Has This Been Tested?
The feature test is readable and easy to understand what is being tested. The test first creates an account, goes to update the partner's password, and check if the new password is valid while making sure that the old password no longers works.
To test manually:
Screenshots