drop support for Laravel 5.4 and require swoole 4.3.1

Author: albertcht

.travis.yml

@@ -4,24 +4,22 @@ sudo: false
 
 matrix:
   include:
-    - php: 7.2
-      env: FRAMEWORK_VERSION=laravel/framework:5.4.*
     - php: 7.2
       env: FRAMEWORK_VERSION=laravel/framework:5.5.*
     - php: 7.2
       env: FRAMEWORK_VERSION=laravel/framework:5.6.*
     - php: 7.2
       env: FRAMEWORK_VERSION=laravel/framework:5.7.*
-    # - php: 7.2
-    #   env: FRAMEWORK_VERSION=laravel/framework:5.8.*
     - php: 7.2
-      env: FRAMEWORK_VERSION=laravel/lumen-framework:5.4.*
+      env: FRAMEWORK_VERSION=laravel/framework:5.8.*
     - php: 7.2
       env: FRAMEWORK_VERSION=laravel/lumen-framework:5.5.*
     - php: 7.2
       env: FRAMEWORK_VERSION=laravel/lumen-framework:5.6.*
     - php: 7.2
       env: FRAMEWORK_VERSION=laravel/lumen-framework:5.7.*
+    - php: 7.2
+      env: FRAMEWORK_VERSION=laravel/lumen-framework:5.8.*
 
 before_install:
   - printf "\n" | pecl install swoole

routes/lumen_routes.php

@@ -11,10 +11,5 @@
 |
 */
 
-$app->get('socket.io', [
-    'as' => 'io.get', 'uses' => 'SocketIOController@upgrade',
-]);
-
-$app->post('socket.io', [
-    'as' => 'io.post', 'uses' => 'SocketIOController@reject',
-]);
+$router->get('socket.io', ['uses' => 'SocketIOController@upgrade']);
+$router->post('socket.io', ['uses' => 'SocketIOController@reject']);

src/Commands/HttpServerCommand.php

@@ -5,13 +5,14 @@
 use Throwable;
 use Swoole\Process;
 use Illuminate\Support\Arr;
+use SwooleTW\Http\Helpers\OS;
 use Illuminate\Console\Command;
 use SwooleTW\Http\Server\Manager;
 use Illuminate\Console\OutputStyle;
 use SwooleTW\Http\HotReload\FSEvent;
-use SwooleTW\Http\Server\AccessOutput;
 use SwooleTW\Http\HotReload\FSOutput;
 use SwooleTW\Http\HotReload\FSProcess;
+use SwooleTW\Http\Server\AccessOutput;
 use SwooleTW\Http\Middleware\AccessLog;
 use SwooleTW\Http\Server\Facades\Server;
 use Illuminate\Contracts\Container\Container;
@@ -372,20 +373,20 @@ protected function isDaemon(): bool
      */
     protected function checkEnvironment()
     {
-        if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
-            $this->error("Swoole extension doesn't support Windows OS yet.");
+        if (OS::is(OS::WIN)) {
+            $this->error('Swoole extension doesn\'t support Windows OS.');
 
             exit(1);
         }
 
         if (! extension_loaded('swoole')) {
-            $this->error("Can't detect Swoole extension installed.");
+            $this->error('Can\'t detect Swoole extension installed.');
 
             exit(1);
         }
 
-        if (! version_compare(swoole_version(), '4.0.0', 'ge')) {
-            $this->error("Your Swoole version must be higher than 4.0 to use coroutine.");
+        if (! version_compare(swoole_version(), '4.3.1', 'ge')) {
+            $this->error('Your Swoole version must be higher than `4.3.1`.');
 
             exit(1);
         }

src/Helpers/FW.php

@@ -47,7 +47,7 @@ final class FW
      */
     public static function is(string ...$types): bool
     {
-        return \in_array(static::current(), $types, true);
+        return in_array(static::current(), $types, true);
     }
 
     /**

src/LumenServiceProvider.php

@@ -31,18 +31,10 @@ protected function registerManager()
      */
     protected function bootWebsocketRoutes()
     {
-        $app = $this->app;
-
-        // router only exists after lumen 5.5
-        if (property_exists($app, 'router')) {
-            $app->router->group(['namespace' => 'SwooleTW\Http\Controllers'], function ($app) {
-                require __DIR__ . '/../routes/lumen_routes.php';
-            });
-        } else {
-            $app->group(['namespace' => 'App\Http\Controllers'], function ($app) {
+        $this->app->router
+            ->group(['namespace' => 'SwooleTW\Http\Controllers'], function ($router) {
                 require __DIR__ . '/../routes/lumen_routes.php';
             });
-        }
     }
 
     /**