staticmethods, wide exception

Author: llybin

sberbank/serializers.py

@@ -9,13 +9,16 @@ class PaymentSerializer(serializers.ModelSerializer):
     system = serializers.SerializerMethodField()
     method = serializers.SerializerMethodField()
 
-    def get_method(self, obj):
+    @staticmethod
+    def get_method(obj):
         return Method(obj.method).name
 
-    def get_status(self, obj):
+    @staticmethod
+    def get_status(obj):
         return Status(obj.status).name
 
-    def get_pan(self, obj):
+    @staticmethod
+    def get_pan(obj):
         return obj.details.get('pan')
 
     def get_system(self, obj):

sberbank/service.py

@@ -59,7 +59,7 @@ def mobile_pay(self, amount, token, ip, **kwargs):
                 method = "google/payment"
                 db_method = Method.GOOGLE
 
-        except:
+        except Exception:
             raise TypeError("Failed to decode payment token")
 
         try:

sberbank/views.py

@@ -18,7 +18,8 @@
 
 
 class StatusView(APIView):
-    def get(self, request, uid=None):
+    @staticmethod
+    def get(request, uid=None):
         try:
             payment = Payment.objects.get(uid=uid)
         except Payment.DoesNotExist:
@@ -27,22 +28,25 @@ def get(self, request, uid=None):
 
 
 class BindingsView(APIView):
-    def get(self, request, client_id=None):
+    @staticmethod
+    def get(request, client_id=None):
         svc = BankService(settings.MERCHANT_KEY)
         return Response(svc.get_bindings(client_id))
 
 
 class BindingView(CsrfExemptMixin, APIView):
     authentication_classes = []
 
-    def delete(self, request, binding_id=None):
+    @staticmethod
+    def delete(request, binding_id=None):
         svc = BankService(settings.MERCHANT_KEY)
         svc.deactivate_binding(binding_id)
         return HttpResponse(status=200)
 
 
 class GetHistoryView(APIView):
-    def get(self, request, client_id=None, format=None):
+    @staticmethod
+    def get(request, client_id=None, format=None):
         payments = Payment.objects.filter(client_id=client_id, status=Status.SUCCEEDED).order_by('-updated')
         serializer = PaymentSerializer(payments, many=True)
         return Response(serializer.data)