Refactor tests and add CentOS6 image

This commit does a fairly major refactor of how the spec tests
are laid out.  The main goal was to make it easier to run
a subset of the tests--e.g., the ability to only run tests
on a single OS via a simple rspec command.

The test logic is now defined in some shared examples in the
`support` directory.  There are now spec folders for each
distro, which contain some stubs to include the shared examples
as well as a Vagrantfile for the particular distro.

Also, the system-default postgres package tests now run
successfully against the CentOS6 VM that is defined by the
Vagrantfile.

Author: cprice404

manifests/initdb.pp

@@ -25,10 +25,16 @@
   $user        = 'postgres'
 ) inherits postgresql::params {
 
-  exec { "${initdb_path} --encoding '${encoding}' --pgdata '${datadir}'":
+  $initdb_command = "${initdb_path} --encoding '${encoding}' --pgdata '${datadir}'"
+
+  exec { $initdb_command:
     creates => "${datadir}/PG_VERSION",
     user    => $user,
-    group   => $group,
-    require => Package["$postgresql::params::server_package_name"],
+    group   => $group
+  }
+
+  if defined(Package["$postgresql::params::server_package_name"]) {
+    Package["$postgresql::params::server_package_name"] ->
+        Exec[$initdb_command]
   }
 }

spec/README.md

@@ -0,0 +1,25 @@
+Warning: these spec tests are pretty resource intensive!
+
+You will need the following in order to run them:
+
+* Virtualbox
+* vagrant
+* 'sahara' gem
+* A decent chunk of free disk space (~300MB per distro tested)
+* Patience :)
+
+If you just run:
+
+    rspec ./spec
+
+then, for each distro that has a Vagrantfile in the spec/distros directory,
+vagrant will download a base image from the web, fire up a VM, and run
+the suite of tests against the VM.
+
+If you only want to run the tests against an individual distro, you can
+instead do something like:
+
+    rspec ./spec/distros/ubuntu_lucid_64
+
+For some options that might speed up the testing process a bit during development,
+please see `spec/support/test_config.rb`.

spec/Vagrantfile

@@ -0,0 +1,12 @@
+require File.expand_path(File.join(__FILE__, '../../../support/vagrant_common'))
+
+Vagrant::Config.run do |config|
+
+  config.vm.define :centos6 do |vm_config|
+      vm_config.vm.box = "cent63_64"
+      vm_config.vm.box_url = "https://dl.dropbox.com/u/7225008/Vagrant/CentOS-6.3-x86_64-minimal.box"
+  end
+
+  apply_common_vagrant_config(config)
+
+end

spec/distros/centos6_64/Vagrantfile

@@ -0,0 +1,7 @@
+require 'support/shared_examples/non_default_postgres'
+
+describe "CentOS6, 64-bit: non-default postgres" do
+  let(:vagrant_dir) { File.dirname(__FILE__) }
+  let(:vm) { :centos6 }
+  it_behaves_like :non_default_postgres
+end

spec/distros/centos6_64/non_default_pg_spec.rb

@@ -0,0 +1,8 @@
+require 'support/shared_examples/system_default_postgres'
+
+describe "CentOS6, 64-bit: default system postgres" do
+  let(:vagrant_dir) { File.dirname(__FILE__) }
+  let(:vm) { :centos6 }
+  let(:service_name) { 'postgresql' }
+  it_behaves_like :system_default_postgres
+end

spec/distros/centos6_64/system_default_pg_spec.rb

@@ -0,0 +1,13 @@
+require File.expand_path(File.join(__FILE__, '../../../support/vagrant_common'))
+
+Vagrant::Config.run do |config|
+
+  config.vm.define :lucid do |vm_config|
+      # Test on 64 bit lucid
+      vm_config.vm.box = "lucid64"
+      vm_config.vm.box_url = "http://files.vagrantup.com/lucid64.box"
+  end
+
+  apply_common_vagrant_config(config)
+
+end

spec/distros/ubuntu_lucid_64/Vagrantfile

@@ -0,0 +1,7 @@
+require 'support/shared_examples/non_default_postgres'
+
+describe "Ubuntu Lucid, 64-bit: non-default postgres" do
+  let(:vagrant_dir) { File.dirname(__FILE__) }
+  let(:vm) { :lucid }
+  it_behaves_like :non_default_postgres
+end

spec/distros/ubuntu_lucid_64/non_default_pg_spec.rb

@@ -0,0 +1,8 @@
+require 'support/shared_examples/system_default_postgres'
+
+describe "Ubuntu Lucid, 64-bit: default system postgres" do
+  let(:vagrant_dir) { File.dirname(__FILE__) }
+  let(:vm) { :lucid }
+  let(:service_name) { 'postgresql-8.4' }
+  it_behaves_like :system_default_postgres
+end

spec/distros/ubuntu_lucid_64/system_default_pg_spec.rb

@@ -18,9 +18,6 @@
 
 class postgresql_tests::test_initdb {
 
-  include postgresql::server
+  include postgresql::initdb
 
-  class { "postgresql::initdb":
-    require => Class['postgresql::server']
-  }
 }