Skip to content

Customer Newsletter subscription label changes. #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Customer Newsletter subscription label changes. #469

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa5e555
customer subscription change text
Nov 12, 2020
20a67e0
Update SubscribeEmailToNewsletter.graphqls
RakeshJesadiya Dec 17, 2020
2f4bfba
Update SubscribeEmailToNewsletter.graphqls
RakeshJesadiya Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update SubscribeEmailToNewsletter.graphqls
  • Loading branch information
@RakeshJesadiya
RakeshJesadiya authored Jan 18, 2021
commit 2f4bfba3d759dde2d18c91b0117fe3c9953f0d0f
1 change: 1 addition & 0 deletions design-documents/graph-ql/coverage/customer/SubscribeEmailToNewsletter.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ type SubscribeEmailToNewsletterOutput {
}

enum SubscriptionStatusesEnum {
Copy link

@dthampy dthampy Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better align with the existing enum values, change "NOT_ACTIVE" status to INACTIVE

Copy link
Contributor

@cpartica cpartica Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but we can't remove that value
we have to keep it, add a comment that's not used and add "INACTIVE" as a new value

NOT_ACTIVE @deprecated(reason: "New value will be `INACTIVE`")
INACTIVE
SUBSCRIBED
UNSUBSCRIBED
Expand Down