Change how duplicate values are stored and add Chinese Traditional for i18n by sangyuxiaowu · Pull Request #161 · massCodeIO/massCode

sangyuxiaowu · 2022-07-21T17:27:19Z

Place the name of the language separately at index.ts so that friends who add new languages can modify only one place and do not modify other localization files.
Added traditional Chinese language and unified naming rules.
Modified the English period in Simplified Chinese.

…ng new localizations.

antonreshetov · 2022-07-22T01:56:36Z

src/main/services/i18n/index.ts

 i18next.use(Backend).init({
  fallbackLng: 'en',
-  lng: store.preferences.get('language'),
+  lng: lng,


No need to duplicate if prop is the same as the name of a local variable

I get it, I tried it and it works. 😀

Use just single lng

Do you mean to change a variable name?

{ lng: lng } equal { lng }

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer

Thanks, I see.

Learned new knowledge

antonreshetov · 2022-07-22T06:20:13Z

src/main/services/i18n/index.ts

  }
 })

+// add language list here


I think we should remove this comment and just update https://github.com/massCodeIO/massCode/blob/master/src/main/services/i18n/locales/README.md

antonreshetov · 2022-07-22T06:22:08Z

src/main/services/i18n/index.ts

 })

+// add language list here
+i18next.addResourceBundle('en', 'language', {


In general, the previous solution looked logical, although the current one works, since it will just be a fallback to en. I do not even know what is more correct )

I'm guessing this is because of the alternate mechanism.
This is handled by mapping, only "en" has this value, so just use it?
Maybe change it to something else and it will work fine.

Reminds me of a comic: it works fine, don't modify it.

Did I misunderstand what you meant before? 😂

I know exactly why it works, because there is a fallback to en if the selected locale has either no translation or no property at all.

I'm just confused which option to leave just. Because they both work.

Let's keep the first option, because even without knowing the logic of i18n, it looks more logical

OK, done.
My git usage is not very good, and the network with github also fluctuates. It took some time.

antonreshetov · 2022-07-22T08:48:38Z

src/main/services/i18n/index.ts

 i18next.use(Backend).init({
  fallbackLng: 'en',
-  lng: store.preferences.get('language'),
+  lng: lngset,


OK, I fix it myself. You need to read the basics of JS

Oh I see. so awkward. I thought it was for code specification and to prevent ambiguity, so I changed the variable name.
I believe that participating in the project can learn a lot, please bear with me.

sangyuxiaowu added 2 commits July 22, 2022 01:16

feat(i18n): Change how duplicate values are stored to facilitate addi…

ded5b37

…ng new localizations.

feat(i18n): add Chinese Traditional for i18n

249eade

antonreshetov reviewed Jul 22, 2022

View reviewed changes

chore: change variable name

a62440e

antonreshetov reviewed Jul 22, 2022

View reviewed changes

chore: format

2597b15

antonreshetov approved these changes Jul 22, 2022

View reviewed changes

antonreshetov merged commit 8b00fcd into massCodeIO:master Jul 22, 2022

Uh oh!

Conversation

sangyuxiaowu commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sangyuxiaowu commented Jul 21, 2022 •

edited

Loading