feat: add DigitalOcean, Moodle and Oracle icons#388
Merged
antonreshetov merged 2 commits intomassCodeIO:masterfrom Jul 18, 2023
Merged
feat: add DigitalOcean, Moodle and Oracle icons#388antonreshetov merged 2 commits intomassCodeIO:masterfrom
antonreshetov merged 2 commits intomassCodeIO:masterfrom
Conversation
Member
|
The files look unoptimized. Use svgo or other svg optimization utilities. Better yet, find a good collection of icons that follow svg best practices. |
Member
|
Big collection of icons https://icones.js.org/ |
|
optimize svg https://jakearchibald.github.io/svgomg/ |
Member
|
The icons should also be fitted into a square and have a margin. You can take any icon from https://github.com/massCodeIO/massCode/tree/master/src/renderer/assets/svg/icons as an example. |
Contributor
Author
|
Got it! Thank you very much. Updated and added also a new one. |
adpe
changed the title
antonreshetov
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Change which was discussed in #385
Validations