Makes trailing slash redirect only apply to GET requests

Author: jacoblee93

lib/gateway.js

@@ -25,6 +25,7 @@ class Gateway extends EventEmitter {
     this.name = cfg.name || DEFAULT_NAME;
     this.maxRequestSizeMB = cfg.maxRequestSizeMB || DEFAULT_MAX_REQUEST_SIZE_MB;
     this.supportedMethods = {'GET': true, 'POST': true, 'OPTIONS': true, 'HEAD': true};
+    this.trailingSlashRedirectMethods = {'GET': true};
     this.supportedLogTypes = {'global': '***', 'info': ':::', 'error': '<!>', 'result': '>>>'};
     this.defaultLogType = 'info';
     this.supportedBgModes = background.modes;
@@ -587,7 +588,12 @@ class Gateway extends EventEmitter {
       this.log(req, `Background Function Initiated`);
     }
 
-    if (req.headers['user-agent'] && !pathname.endsWith('/') && pathname.split('/').pop().indexOf('.') === -1) {
+    if (
+      this.trailingSlashRedirectMethods[req.method] &&
+      req.headers['user-agent'] &&
+      !pathname.endsWith('/') &&
+      pathname.split('/').pop().indexOf('.') === -1
+    ) {
       this.log(req, `Redirect`);
       if (pathinfo.length === 2) {
         pathinfo[0] = pathname + '/';

package.json

@@ -1,6 +1,6 @@
 {
   "name": "functionscript",
-  "version": "1.7.1",
+  "version": "1.8.0",
   "description": "A language and specification for turning JavaScript functions into typed HTTP APIs",
   "author": "Keith Horwood <[email protected]>",
   "main": "index.js",

tests/gateway/tests.js

@@ -79,7 +79,7 @@ module.exports = (expect) => {
     });
   });
 
-  it('Should return 302 redirect when missing trailing / with user agent', done => {
+  it('Should return 302 redirect on GET request when missing trailing / with user agent', done => {
     request('GET', {'user-agent': 'testing'}, '/my_function', '', (err, res, result) => {
 
       expect(err).to.not.exist;
@@ -94,7 +94,7 @@ module.exports = (expect) => {
     });
   });
 
-  it('Should not return 302 redirect when missing trailing / without user agent', done => {
+  it('Should not return 302 redirect on a GET request when missing trailing / without user agent', done => {
     request('GET', {}, '/my_function', '', (err, res, result) => {
 
       expect(err).to.not.exist;
@@ -107,6 +107,19 @@ module.exports = (expect) => {
     });
   });
 
+  it('Should not return 302 redirect for POST request with trailing slash with user agent', done => {
+    request('POST', {'user-agent': 'testing'}, '/my_function', '', (err, res, result) => {
+
+      expect(err).to.not.exist;
+      expect(res.statusCode).to.not.equal(302);
+      expect(res.headers).to.haveOwnProperty('access-control-allow-origin');
+      expect(res.headers).to.haveOwnProperty('access-control-allow-headers');
+      expect(res.headers).to.haveOwnProperty('access-control-expose-headers');
+      done();
+
+    });
+  });
+
   it('Should give 200 OK and property headers for OPTIONS', done => {
     request('OPTIONS', {}, '/my_function/', {}, (err, res, result) => {
 
@@ -695,8 +708,8 @@ module.exports = (expect) => {
     });
   });
 
-  it('Should return 302 redirect with correct url when running a background function missing a slash before :bg and at end of url', done => {
-    request('POST', {'user-agent': 'testing'}, '/bg:bg', '', (err, res, result) => {
+  it('Should return 302 redirect on a GET request with correct url when running a background function missing a slash before :bg and at end of url', done => {
+    request('GET', {'user-agent': 'testing'}, '/bg:bg', '', (err, res, result) => {
 
       expect(err).to.not.exist;
       expect(res.statusCode).to.equal(302);
@@ -710,8 +723,8 @@ module.exports = (expect) => {
     });
   });
 
-  it('Should return 302 redirect with correct url when running a background function missing a slash before :bg but with slash at end of url', done => {
-    request('POST', {'user-agent': 'testing'}, '/bg:bg/', '', (err, res, result) => {
+  it('Should return 302 redirect on a GET request with correct url when running a background function missing a slash before :bg but with slash at end of url', done => {
+    request('GET', {'user-agent': 'testing'}, '/bg:bg/', '', (err, res, result) => {
 
       expect(err).to.not.exist;
       expect(res.statusCode).to.equal(302);
@@ -725,8 +738,8 @@ module.exports = (expect) => {
     });
   });
 
-  it('Should return 302 redirect with correct url when running a background function missing a slash before :bg and at end of url with a query', done => {
-    request('POST', {'user-agent': 'testing'}, '/bg:bg?test=param', '', (err, res, result) => {
+  it('Should return 302 redirect on a GET request with correct url when running a background function missing a slash before :bg and at end of url with a query', done => {
+    request('GET', {'user-agent': 'testing'}, '/bg:bg?test=param', '', (err, res, result) => {
 
       expect(err).to.not.exist;
       expect(res.statusCode).to.equal(302);
@@ -740,8 +753,8 @@ module.exports = (expect) => {
     });
   });
 
-  it('Should return 302 redirect with correct url when running a background function missing a slash before :bg but with slash at end of url with a query', done => {
-    request('POST', {'user-agent': 'testing'}, '/bg:bg/?test=param', '', (err, res, result) => {
+  it('Should return 302 redirect on a GET request with correct url when running a background function missing a slash before :bg but with slash at end of url with a query', done => {
+    request('GET', {'user-agent': 'testing'}, '/bg:bg/?test=param', '', (err, res, result) => {
 
       expect(err).to.not.exist;
       expect(res.statusCode).to.equal(302);