Conversation
LeoMcA
commented
Jan 20, 2026
Contributor
|
84365a1 was deployed to: https://fred-pr1230.review.mdn.allizom.net/ |
caugner
approved these changes
Jan 20, 2026
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
LGTM overall, just three comments.
caugner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1227 requires a new, square, social image.
I thought it would be fun to implement this as a component, and help maintainability in the future: e.g. it takes colours direct from our colour theme, and if we wanted to generate custom thumbnails for each page using HTML/CSS this would give us a starting point.